Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pileup scenario for 2018 using an extrapolation of data to date. #23613

Merged
merged 3 commits into from Jun 20, 2018

Conversation

plujan
Copy link
Contributor

@plujan plujan commented Jun 18, 2018

This uses the 2018 data so far, extrapolated over the rest of the year. For more details see the slides here: https://indico.cern.ch/event/737811/contributions/3045257/attachments/1670000/2678601/pu_projections_2018_june.pdf

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @plujan (Paul Lujan) for master.

It involves the following packages:

Configuration/StandardSequences
SimGeneral/MixingModule

@civanch, @mdhildreth, @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@plujan
Copy link
Contributor Author

plujan commented Jun 18, 2018

Hi all,

I just learned that the distribution here has not yet been smeared as we planned, so I'll get that updated as soon as possible.

Sorry for the inconvenience!

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #23613 was updated. @civanch, @mdhildreth, @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please check and sign again.

@plujan
Copy link
Contributor Author

plujan commented Jun 18, 2018

The file now includes the properly smeared version. Here's the plot of the distributions:

pileupsummer2018

@franzoni
Copy link

hi @plujan , thanks for this.

"Summer18" is already taken as a name:
it's the ongoing MC campaign based on 10_1 .

Would it be possible to rename this scenario, to avoid mis-understanding pls.
"JuneProjectionFull18", or a better idea ?

Including PdmV convenors who master the naming of 10_2 based MC campaign
@fabozzi @prebello @GurpreetSinghChahal

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@plujan
Copy link
Contributor Author

plujan commented Jun 19, 2018

Sure, done! Also, tested with cmsDriver to make sure everything actually works, and it looks fine.

@cmsbuild
Copy link
Contributor

Pull request #23613 was updated. @civanch, @mdhildreth, @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please check and sign again.

@fabiocos
Copy link
Contributor

please test

testing nothing in reality, I do not see a way to do it from the bot until this scenario is not put as default for some test wf

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 19, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28755/console Started: 2018/06/19 10:12

@plujan
Copy link
Contributor Author

plujan commented Jun 19, 2018

@fabiocos Yeah agreed -- I just tested it by picking a random workflow and changing the cmsDriver command to include the new scenario, but there's not really much more that can be done.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23613/28755/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2902013
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901822
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@civanch
Copy link
Contributor

civanch commented Jun 19, 2018

+1

@fabiocos
Copy link
Contributor

+operations

simple addition of a new PU scenario to StandardSequences

@fabiocos
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit ec93696 into cms-sw:master Jun 20, 2018
@franzoni
Copy link

Tks!!

@plujan plujan deleted the PileupSummer18 branch June 22, 2018 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants