Adding in Muon Efficiency Maps #23614

ocolegro · 2018-06-18T16:44:22Z

Adding Muon Efficiency maps to the DQM GUI for fast tracking efficiency studies.

cmsbuild · 2018-06-18T16:44:40Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-06-18T16:51:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23614/5236

cmsbuild · 2018-06-18T16:51:50Z

A new Pull Request was created by @ocolegro for master.

It involves the following packages:

DQM/TrackingMonitor
DQM/TrackingMonitorClient
DQM/TrackingMonitorSource

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@hdelanno, @makortel, @mtosi, @fioriNTU, @jandrea, @idebruyn, @threus this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2018-06-18T16:53:11Z

please test

cmsbuild · 2018-06-18T16:53:29Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28743/console Started: 2018/06/18 18:54

cmsbuild · 2018-06-18T22:46:27Z

-1

Tested at: 2bd5521

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23614/28743/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

The relvals timed out after 2 hours.

cmsbuild · 2018-06-18T22:46:30Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

fioriNTU · 2018-06-19T07:10:12Z

DQM/TrackingMonitor/src/TrackEfficiencyMonitor.cc

-
+
+  edm::Handle<edm::View<reco::Muon> > muons; 
+  iEvent.getByToken(muonToken_,muons);


@ocolegro please add a check on the validity of the muon collection here, this part may cause issues in the Online clients if the muons are not reconstructed

I agree on the comment by @fioriNTU A prevention is needed please

jandrea · 2018-06-19T07:20:20Z

I am trying to understand the origin of the error. It doesn't seem related to the modifications made by Owen (?).

----- Begin Fatal Exception 19-Jun-2018 06:45:06 CEST-----------------------
An exception of category 'Configuration' occurred while
[0] Constructing the EventProcessor
[1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

boudoul · 2018-06-19T07:27:15Z

Hi @jandrea , as you can see the error is a timeout - The tests should be realaunched

jfernan2 · 2018-06-19T07:28:39Z

please test

cmsbuild · 2018-07-23T16:01:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23614/5647

cmsbuild · 2018-07-23T16:03:07Z

Pull request #23614 was updated. @andrius-k, @kmaeshima, @schneiml, @dmitrijus, @cmsbuild, @jfernan2 can you please check and sign again.

andrius-k · 2018-07-23T16:24:57Z

please test

cmsbuild · 2018-07-23T16:25:18Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29346/console Started: 2018/07/23 18:25

cmsbuild · 2018-07-23T19:22:48Z

+1
Tested at: 4ffaf58
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23614/29346/summary.html

cmsbuild · 2018-07-23T19:22:51Z

Comparison job queued.

cmsbuild · 2018-07-23T20:21:06Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23614/29346/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2889291
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2889094
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 646.115 KiB( 30 files compared)
DQMHistoSizes: changed ( 20034.0,... ): 28.487 KiB Tracking/TrackParameters
DQMHistoSizes: changed ( 7.3,... ): 11.757 KiB Tracking/TrackParameters
DQMHistoSizes: changed ( 7.3,... ): 11.610 KiB Muons/cosmicMuons
DQMHistoSizes: changed ( 7.3,... ): 11.587 KiB Muons/TKTrack
Checked 128 log files, 14 edm output root files, 31 DQM output files

andrius-k · 2018-07-26T09:54:38Z

+1

cmsbuild · 2018-07-26T09:54:59Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

kpedro88 · 2018-07-27T15:51:01Z

+1

VinInn · 2018-08-14T15:56:03Z

It seems to me that this PR is polluting the top level tracking folder
https://goo.gl/qCkciN
please FIX
-1

VinInn · 2018-08-14T16:10:12Z

@mtosi @JanFSchulte

mtosi · 2018-08-17T16:13:48Z

@ocolegro @jandrea are you planning to fix this ? or shall I do it ? thanks

mtosi · 2018-08-17T16:17:32Z

in addition, may I ask why you are not using the DQMGenericClient for doing the efficiency plots ?

ocolegro added 2 commits June 18, 2018 18:40

Adding in Muon Efficiency Maps

9ca4ad9

Adding in Muon Efficiency Maps

2bd5521

cmsbuild added this to the CMSSW_10_2_X milestone Jun 18, 2018

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Jun 18, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 18, 2018

cmsbuild added tests-started and removed tests-pending labels Jun 18, 2018

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jun 18, 2018

fioriNTU reviewed Jun 19, 2018

View reviewed changes

cmsbuild removed comparison-notrun tests-rejected labels Jun 19, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 23, 2018

cmsbuild added tests-started and removed tests-pending labels Jul 23, 2018

cmsbuild added tests-approved and removed tests-started labels Jul 23, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jul 23, 2018

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jul 26, 2018

cmsbuild added orp-approved and removed orp-pending labels Jul 27, 2018

cmsbuild merged commit 68b56b2 into cms-sw:master Jul 27, 2018

mmusich mentioned this pull request Jan 29, 2020

Tracking DQM: miscellaneous fixes #28823

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding in Muon Efficiency Maps #23614

Adding in Muon Efficiency Maps #23614

ocolegro commented Jun 18, 2018

cmsbuild commented Jun 18, 2018

cmsbuild commented Jun 18, 2018

cmsbuild commented Jun 18, 2018

jfernan2 commented Jun 18, 2018

cmsbuild commented Jun 18, 2018 •

edited

cmsbuild commented Jun 18, 2018

cmsbuild commented Jun 18, 2018

fioriNTU Jun 19, 2018

jfernan2 Jun 21, 2018

jandrea commented Jun 19, 2018

boudoul commented Jun 19, 2018

jfernan2 commented Jun 19, 2018

cmsbuild commented Jul 23, 2018

cmsbuild commented Jul 23, 2018

andrius-k commented Jul 23, 2018

cmsbuild commented Jul 23, 2018 •

edited

cmsbuild commented Jul 23, 2018

cmsbuild commented Jul 23, 2018

cmsbuild commented Jul 23, 2018

andrius-k commented Jul 26, 2018

cmsbuild commented Jul 26, 2018

kpedro88 commented Jul 27, 2018

VinInn commented Aug 14, 2018

VinInn commented Aug 14, 2018

mtosi commented Aug 17, 2018

mtosi commented Aug 17, 2018



		edm::Handle<edm::View<reco::Muon> > muons;
		iEvent.getByToken(muonToken_,muons);

Adding in Muon Efficiency Maps #23614

Adding in Muon Efficiency Maps #23614

Conversation

ocolegro commented Jun 18, 2018

cmsbuild commented Jun 18, 2018

cmsbuild commented Jun 18, 2018

cmsbuild commented Jun 18, 2018

jfernan2 commented Jun 18, 2018

cmsbuild commented Jun 18, 2018 • edited

cmsbuild commented Jun 18, 2018

cmsbuild commented Jun 18, 2018

fioriNTU Jun 19, 2018

Choose a reason for hiding this comment

jfernan2 Jun 21, 2018

Choose a reason for hiding this comment

jandrea commented Jun 19, 2018

boudoul commented Jun 19, 2018

jfernan2 commented Jun 19, 2018

cmsbuild commented Jul 23, 2018

cmsbuild commented Jul 23, 2018

andrius-k commented Jul 23, 2018

cmsbuild commented Jul 23, 2018 • edited

cmsbuild commented Jul 23, 2018

cmsbuild commented Jul 23, 2018

cmsbuild commented Jul 23, 2018

andrius-k commented Jul 26, 2018

cmsbuild commented Jul 26, 2018

kpedro88 commented Jul 27, 2018

VinInn commented Aug 14, 2018

VinInn commented Aug 14, 2018

mtosi commented Aug 17, 2018

mtosi commented Aug 17, 2018

cmsbuild commented Jun 18, 2018 •

edited

cmsbuild commented Jul 23, 2018 •

edited