[muon] reco to trigger object matching #23636

drkovalskyi · 2018-06-21T20:03:53Z

This PR implements a proper matching of offline reco muons to L1 and HLT muon objects for trigger studies. L1 matching requires propagation to MB2/ME2, which is avoided by using the muon matching information. HLT matching is complicated by lack of a single muon hlt object producer and name changes of the primary producers during Run2. Fortunately in practice we almost always had just one primary muon producer used in all the main triggers, so the matching is solid and covers majority of use cases (it is not meant to replace results of advanced archaeology that one may want to do in a case of some special triggers).

…B2/ME2

cmsbuild · 2018-06-21T20:04:11Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-06-21T20:07:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23636/5283

cmsbuild · 2018-06-21T20:07:51Z

A new Pull Request was created by @drkovalskyi for master.

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos

@perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @rappoccio, @HeinerTholen, @seemasharmafnal, @mmarionncern, @imarches, @ahinzmann, @smoortga, @acaudron, @jdolen, @ferencek, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @clelange, @JyothsnaKomaragiri, @mverzett, @cbernet, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

slava77 · 2018-06-22T03:59:17Z

@cmsbuild please test

cmsbuild · 2018-06-22T03:59:59Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28811/console Started: 2018/06/22 06:00

slava77 · 2018-06-22T04:02:57Z

PhysicsTools/PatAlgos/plugins/PATMuonProducer.cc

@@ -179,6 +185,10 @@ PATMuonProducer::PATMuonProducer(const edm::ParameterSet & iConfig, PATMuonHeavy
  // MC info
  simInfo_        = consumes<edm::ValueMap<reco::MuonSimInfo> >(iConfig.getParameter<edm::InputTag>("muonSimInfo"));

+  triggerObjects_ = consumes<std::vector<pat::TriggerObjectStandAlone>>(edm::InputTag("slimmedPatTrigger"));
+  if (iConfig.exists("hltCollectionNames"))


please add a default values to ::fillDescriptions.
This will also drop the need to use ::exists, which is strongly discouraged

slava77 · 2018-06-22T04:03:17Z

PhysicsTools/PatAlgos/plugins/PATMuonProducer.cc

+      if (deltaR(triggerObjects->at(i).p4(),*muonPosition)>0.1) continue;
+      // printf("muon pt: %4.1f eta: %+5.3f phi: %+5.3f\n", aMuon.pt(), aMuon.eta(), aMuon.phi());
+      // if (muonPosition) printf("global direction MB2/ME2: eta: %+5.3f phi: %+5.3f\n",double(muonPosition->eta()), double(muonPosition->phi()));
+      // printf("L1 pt: %4.1f eta: %+5.3f phi: %+5.3f\n",triggerObjects->at(i).pt(), triggerObjects->at(i).eta(), triggerObjects->at(i).phi());


is this commented out code needed?
Please remove or add comments inline in the code why the commented out block is relevant

slava77 · 2018-06-22T04:03:32Z

PhysicsTools/PatAlgos/plugins/PATMuonProducer.h

+#include "DataFormats/PatCandidates/interface/TriggerObjectStandAlone.h"
+#include "Geometry/Records/interface/GlobalTrackingGeometryRecord.h"
+// #include "DataFormats/GeometryVector/interface/GlobalVector.h"
+// #include "DataFormats/GeometryVector/interface/LocalVector.h"


is this commented out code needed?
Please remove or add comments inline in the code why the commented out block is relevant

cmsbuild · 2018-06-22T06:49:28Z

-1

Tested at: 62e79e1

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23636/28811/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals AddOn

Unit Tests:

I found errors in the following unit tests:

---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafTopJetCombination had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafTopKinFitter had ERRORS
---> test runtestTqafTopHitFit had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test runtestTqafExamples had ERRORS

RelVals:

When I ran the RelVals I found an error in the following worklfows:
135.4 step3

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step3_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

1000.0 step3

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step3_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

AddOn:

I found errors in the following addon tests:

cmsRun /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-21-1100/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py : FAILED - time: date Fri Jun 22 08:19:27 2018-date Fri Jun 22 08:18:44 2018 s - exit: 17920

cmsbuild · 2018-06-22T06:49:30Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2018-06-26T07:37:11Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28889/console Started: 2018/06/26 09:59

cmsbuild · 2018-06-26T11:33:38Z

+1
Tested at: d5e7f1d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23636/28889/summary.html

cmsbuild · 2018-06-26T11:33:41Z

Comparison job queued.

fabozzi · 2018-06-26T11:54:37Z

+1

cmsbuild · 2018-06-26T13:10:27Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23636/28889/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2899480
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2899289
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

gpetruc · 2018-06-26T13:49:20Z

+1
we may decide in the future to change PATObject.h to allow storing the matches also by reference and recover some disk space, but I think we can take this as is for now.

fabiocos · 2018-06-26T13:59:52Z

+operations

cmsbuild · 2018-06-26T14:00:16Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-06-26T14:00:31Z

+1

drkovalskyi added 5 commits June 20, 2018 13:50

added l1 matching in minionaod

e3597ff

made L1 trigger matching more precise by computing muon location at M…

7634efd

…B2/ME2

added hlt muon object

ec92bf4

added hlt muon matching

944e742

no need for era for now

62e79e1

cmsbuild added this to the CMSSW_10_2_X milestone Jun 21, 2018

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jun 21, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 21, 2018

cmsbuild added tests-started and removed tests-pending labels Jun 22, 2018

slava77 reviewed Jun 22, 2018

View reviewed changes

cmsbuild added comparison-notrun and removed comparison-pending tests-started labels Jun 22, 2018

cmsbuild added comparison-pending tests-pending labels Jun 26, 2018

cmsbuild added tests-started and removed tests-pending labels Jun 26, 2018

cmsbuild added tests-approved and removed tests-started labels Jun 26, 2018

cmsbuild added pdmv-approved and removed pdmv-pending labels Jun 26, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jun 26, 2018

cmsbuild added analysis-approved and removed analysis-pending labels Jun 26, 2018

cmsbuild added fully-signed operations-approved and removed operations-pending pending-signatures labels Jun 26, 2018

cmsbuild added orp-approved and removed orp-pending labels Jun 26, 2018

cmsbuild merged commit 73d2d0b into cms-sw:master Jun 26, 2018

This was referenced Jun 28, 2018

Problem in ZMuSkimPath #23704

Closed

Revert "[muon] reco to trigger object matching" #23705

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[muon] reco to trigger object matching #23636

[muon] reco to trigger object matching #23636

drkovalskyi commented Jun 21, 2018

cmsbuild commented Jun 21, 2018

cmsbuild commented Jun 21, 2018

cmsbuild commented Jun 21, 2018

slava77 commented Jun 22, 2018

cmsbuild commented Jun 22, 2018 •

edited

slava77 Jun 22, 2018

slava77 Jun 22, 2018

slava77 Jun 22, 2018

cmsbuild commented Jun 22, 2018

cmsbuild commented Jun 22, 2018

cmsbuild commented Jun 26, 2018 •

edited

cmsbuild commented Jun 26, 2018

cmsbuild commented Jun 26, 2018

fabozzi commented Jun 26, 2018

cmsbuild commented Jun 26, 2018

gpetruc commented Jun 26, 2018

fabiocos commented Jun 26, 2018

cmsbuild commented Jun 26, 2018

fabiocos commented Jun 26, 2018

[muon] reco to trigger object matching #23636

[muon] reco to trigger object matching #23636

Conversation

drkovalskyi commented Jun 21, 2018

cmsbuild commented Jun 21, 2018

cmsbuild commented Jun 21, 2018

cmsbuild commented Jun 21, 2018

slava77 commented Jun 22, 2018

cmsbuild commented Jun 22, 2018 • edited

slava77 Jun 22, 2018

Choose a reason for hiding this comment

slava77 Jun 22, 2018

Choose a reason for hiding this comment

slava77 Jun 22, 2018

Choose a reason for hiding this comment

cmsbuild commented Jun 22, 2018

cmsbuild commented Jun 22, 2018

cmsbuild commented Jun 26, 2018 • edited

cmsbuild commented Jun 26, 2018

cmsbuild commented Jun 26, 2018

fabozzi commented Jun 26, 2018

cmsbuild commented Jun 26, 2018

gpetruc commented Jun 26, 2018

fabiocos commented Jun 26, 2018

cmsbuild commented Jun 26, 2018

fabiocos commented Jun 26, 2018

cmsbuild commented Jun 22, 2018 •

edited

cmsbuild commented Jun 26, 2018 •

edited