[L1T][DQMOffline] L1TEGammaOffline fixes (CMSLITDPG-585)

[kreczko]

Jira issue: https://its.cern.ch/jira/browse/CMSLITDPG-585

Fixes:

• early stopping in probe matching
• adjusted cuts for efficiency vs η/φ

@thomreis I am not quite sure if the cuts are as requested, could you please check?

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23679/5339

[cmsbuild]

A new Pull Request was created by @kreczko (Luke Kreczko) for master.

It involves the following packages:

DQMOffline/L1Trigger

@cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please review it and eventually sign? Thanks.
@thomreis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28895/console Started: 2018/06/26 10:37

[cmsbuild]

+1
Tested at: e4eed9c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23679/28895/summary.html

[cmsbuild]

Comparison job queued.

[dmitrijus]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23679/28895/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2899480
• DQMHistoTests: Total failures: 16
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2899274
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[cmsbuild]

-1

Tested at: e4eed9c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23679/29072/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found an error when building:

>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-07-10-2300/src/DQMServices/Examples/src/DQMClientExample.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-07-10-2300/src/DQMServices/Examples/src/HarvestingAnalyzer.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-07-10-2300/src/DQMServices/Examples/src/HarvestingDataCertification.cc 
>> Building shared library tmp/slc6_amd64_gcc630/src/DQMServices/Examples/src/DQMServicesExamples/libDQMServicesExamples.so
/cvmfs/cms-ib.cern.ch/nweek-02532/slc6_amd64_gcc630/external/gcc/6.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/6.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lDataFormatsParticleFlowCandidate
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc6_amd64_gcc630/src/DQMServices/Examples/src/DQMServicesExamples/libDQMServicesExamples.so] Error 1
Leaving library rule at DQMServices/Examples
>> Leaving Package DQMServices/Examples
>> Package DQMServices/Examples built
>> Leaving Package DQMServices/Examples


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[fabiocos]

the problem seems related to a system-wide trouble, not to this specific PR

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29085/console Started: 2018/07/12 11:04

[cmsbuild]

+1
Tested at: e4eed9c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23679/29085/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23679/29085/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2892290
• DQMHistoTests: Total failures: 16
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2892084
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[thomreis]

Hi @kreczko
now that the master points to 10_3_X you might also want to make a PR to the 10_2_X branch.

[fabiocos]

+1