New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pu jets in jet-core tracking for pp_on_AA_2018 #23684
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23684/5344 |
A new Pull Request was created by @stepobr for master. It involves the following packages: RecoJets/JetProducers @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@fabiocos |
+1 this PR modifies the physics output, but affecting only the processing of HI data, that is not the target of 10_2_X. So I consider as safe to add it even after the end of developments |
This PR makes one change to the tracking in the pp_on_AA_2018 era to be used for PbPb data this year. The default jet-core collection (ak4CaloJetsForTrk) is replaced by a similar one that applies PU subtraction. This allows proper tracking behaviour in PbPb, and is especially crucial for central events.
@abaty @cfmcginn @FHead @mandrenguyen