Do not catch polymorphic exception by value [CondDB] #23719

Dr15Jones · 2018-06-28T21:19:53Z

Fixes a gcc810 compiler warning.

cmsbuild · 2018-06-28T21:21:02Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-06-28T21:24:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23719/5370

Dr15Jones · 2018-06-28T21:24:33Z

please test

cmsbuild · 2018-06-28T21:25:00Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28947/console Started: 2018/06/28 23:25

cmsbuild · 2018-06-28T21:25:01Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CondCore/CondDB

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2018-06-29T02:43:49Z

-1

Tested at: 7506e78

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a674e1f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23719/28947/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23719/28947/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23719/28947/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake2 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --fileout file:RelVal_Raw_Fake2_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Fri Jun 29 03:57:55 2018-date Fri Jun 29 03:51:05 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02530/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_2_X_2018-06-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Jun 29 03:57:55 2018-date Fri Jun 29 03:51:05 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Fri Jun 29 03:57:55 2018-date Fri Jun 29 03:51:05 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PRef --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --eventcontent RAW --fileout file:RelVal_Raw_PRef_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Fri Jun 29 03:58:15 2018-date Fri Jun 29 03:51:12 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02530/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_2_X_2018-06-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Jun 29 03:58:15 2018-date Fri Jun 29 03:51:12 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Fri Jun 29 03:58:15 2018-date Fri Jun 29 03:51:12 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full2015Data --data --scenario=HeavyIons -n 10 --conditions auto:run2_hlt_HIon --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --fileout file:RelVal_Raw_HIon_DATA.root --filein /store/hidata/HIRun2015/HIHardProbes/RAW-RECO/HighPtJet-PromptReco-v1/000/263/689/00000/1802CD9A-DDB8-E511-9CF9-02163E0138CA.root : FAILED - time: date Fri Jun 29 03:57:48 2018-date Fri Jun 29 03:51:13 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02530/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_2_X_2018-06-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Jun 29 03:57:48 2018-date Fri Jun 29 03:51:13 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Fri Jun 29 03:57:48 2018-date Fri Jun 29 03:51:13 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PIon --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --eventcontent RAW --fileout file:RelVal_Raw_PIon_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Fri Jun 29 04:08:38 2018-date Fri Jun 29 03:57:56 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02530/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_2_X_2018-06-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Jun 29 04:08:38 2018-date Fri Jun 29 03:57:56 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Fri Jun 29 04:08:38 2018-date Fri Jun 29 03:57:56 2018 s - exit: 21504
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02530/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_2_X_2018-06-27-2300/src/Utilities/ReleaseScripts/scripts/read312RV_cfg.py : FAILED - time: date Fri Jun 29 04:19:19 2018-date Fri Jun 29 04:12:09 2018 s - exit: 23552
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_2018v22 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --fileout file:RelVal_Raw_2018v22_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Fri Jun 29 04:24:35 2018-date Fri Jun 29 04:15:43 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02530/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_2_X_2018-06-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_2018v22.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Jun 29 04:24:35 2018-date Fri Jun 29 04:15:43 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:2018v22,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2018v22 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_2018v22_DATA.root --fileout file:RelVal_Raw_2018v22_DATA_HLT_RECO.root : FAILED - time: date Fri Jun 29 04:24:35 2018-date Fri Jun 29 04:15:43 2018 s - exit: 21504

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a674e1f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23719/28947/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23719/28947/git-merge-result

cmsbuild · 2018-06-29T02:43:52Z

Comparison job queued.

Dr15Jones · 2018-06-29T03:12:14Z

Please test

cmsbuild · 2018-06-29T03:14:01Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28948/console Started: 2018/06/29 05:16

cmsbuild · 2018-06-29T08:00:13Z

+1
Tested at: 7506e78
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23719/28948/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a674e1f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23719/28948/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23719/28948/git-merge-result

cmsbuild · 2018-06-29T08:00:16Z

Comparison job queued.

ggovi · 2018-07-03T14:20:15Z

+1

cmsbuild · 2018-07-03T14:20:33Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-07-03T14:28:37Z

@smuzaffar I see an issue reproted in the new section https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23719/28975/headers_chks.log that seems unrelated to this PR, but it caught in the test.

We may clean it separartely

smuzaffar · 2018-07-03T15:22:18Z

@fabiocos , this header check failure looks like a glitch in CVMFS. The missing file error

fatal error: FWCore/Utilities/interface/Exception.h: No such file or directory

is false, I can not reproduce it.

fabiocos · 2018-07-05T11:13:34Z

please test

cmsbuild · 2018-07-05T11:13:53Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29013/console Started: 2018/07/05 14:28

cmsbuild · 2018-07-05T17:05:48Z

+1
Tested at: 7506e78
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23719/29013/summary.html

cmsbuild · 2018-07-05T17:05:51Z

Comparison job queued.

cmsbuild · 2018-07-05T18:24:20Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23719/29013/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2899480
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2899289
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

fabiocos · 2018-07-06T08:12:02Z

+1

Do not catch polymorphic exception by value

7506e78

Fixes a gcc810 compiler warning.

cmsbuild added this to the CMSSW_10_2_X milestone Jun 28, 2018

cmsbuild added code-checks-pending comparison-pending db-pending orp-pending pending-signatures tests-pending labels Jun 28, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 28, 2018

cmsbuild added tests-started and removed tests-pending labels Jun 28, 2018

cmsbuild added tests-rejected and removed tests-started labels Jun 29, 2018

cmsbuild added tests-pending and removed tests-rejected labels Jun 29, 2018

cmsbuild added tests-started and removed tests-pending labels Jun 29, 2018

cmsbuild removed the tests-started label Jun 29, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jul 2, 2018

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Jul 3, 2018

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Jul 5, 2018

cmsbuild added tests-started and removed tests-pending labels Jul 5, 2018

cmsbuild added tests-approved and removed tests-started labels Jul 5, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jul 5, 2018

cmsbuild added orp-approved and removed orp-pending labels Jul 6, 2018

cmsbuild merged commit c9f5fa6 into cms-sw:master Jul 6, 2018

Dr15Jones deleted the polymorphicCatchCondDBUtils branch July 6, 2018 16:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not catch polymorphic exception by value [CondDB] #23719

Do not catch polymorphic exception by value [CondDB] #23719

Dr15Jones commented Jun 28, 2018

cmsbuild commented Jun 28, 2018

cmsbuild commented Jun 28, 2018

Dr15Jones commented Jun 28, 2018

cmsbuild commented Jun 28, 2018 •

edited

cmsbuild commented Jun 28, 2018

cmsbuild commented Jun 29, 2018

cmsbuild commented Jun 29, 2018

Dr15Jones commented Jun 29, 2018

cmsbuild commented Jun 29, 2018 •

edited

cmsbuild commented Jun 29, 2018

cmsbuild commented Jun 29, 2018

ggovi commented Jul 3, 2018

cmsbuild commented Jul 3, 2018

fabiocos commented Jul 3, 2018

smuzaffar commented Jul 3, 2018

fabiocos commented Jul 5, 2018

cmsbuild commented Jul 5, 2018 •

edited

cmsbuild commented Jul 5, 2018

cmsbuild commented Jul 5, 2018

cmsbuild commented Jul 5, 2018

fabiocos commented Jul 6, 2018

Do not catch polymorphic exception by value [CondDB] #23719

Do not catch polymorphic exception by value [CondDB] #23719

Conversation

Dr15Jones commented Jun 28, 2018

cmsbuild commented Jun 28, 2018

cmsbuild commented Jun 28, 2018

Dr15Jones commented Jun 28, 2018

cmsbuild commented Jun 28, 2018 • edited

cmsbuild commented Jun 28, 2018

cmsbuild commented Jun 29, 2018

cmsbuild commented Jun 29, 2018

Dr15Jones commented Jun 29, 2018

cmsbuild commented Jun 29, 2018 • edited

cmsbuild commented Jun 29, 2018

cmsbuild commented Jun 29, 2018

ggovi commented Jul 3, 2018

cmsbuild commented Jul 3, 2018

fabiocos commented Jul 3, 2018

smuzaffar commented Jul 3, 2018

fabiocos commented Jul 5, 2018

cmsbuild commented Jul 5, 2018 • edited

cmsbuild commented Jul 5, 2018

cmsbuild commented Jul 5, 2018

cmsbuild commented Jul 5, 2018

fabiocos commented Jul 6, 2018

cmsbuild commented Jun 28, 2018 •

edited

cmsbuild commented Jun 29, 2018 •

edited

cmsbuild commented Jul 5, 2018 •

edited