Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[muon] Enabled trigger matching and minor improvements to the matching algorithm #23728

Merged
merged 2 commits into from Jul 3, 2018

Conversation

drkovalskyi
Copy link
Contributor

@drkovalskyi drkovalskyi commented Jul 1, 2018

  • Small changes in the L1 object matching requirements to address some conner cases like L1 objects defined in X-Y plain etc.
  • Re-enable the trigger matching. I don't expect any issues with clones since by default the trigger matching is disabled. For patMuons the HLT process name is properly synchronized with the patTrigger and slimmedPatTrigger in the ConfigBuilder. It's critical to have this in the final CMSSW_10_2_X release, but it's not really needed for the release validation, since it only adds new information without touching already existing data.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2018

A new Pull Request was created by @drkovalskyi for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @rappoccio, @HeinerTholen, @seemasharmafnal, @mmarionncern, @imarches, @ahinzmann, @smoortga, @acaudron, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @clelange, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28963/console Started: 2018/07/01 18:58

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23728/28963/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2899480
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2899289
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jul 2, 2018

+1

for #23728 e57a375

  • changes in PATMuonProducer.cc are in line with the PR description
  • jenkins tests pass and comparisons with the baseline show no differences (the muon trigger objects are not monitored)

@drkovalskyi this PR includes #23721
please add details about it to this PR description.
Also, if not done already, please add to the tasklist for the MUO POG some monitoring to be added for the muon trigger objects in miniAOD. It can go with the DQM or validation sequences in @miniAODDQM or/and @miniAODValidation

@drkovalskyi drkovalskyi changed the title [muon] Trigger matching improvement [muon] Enabled trigger matching and minor improvements to the matching algorithm Jul 2, 2018
@drkovalskyi
Copy link
Contributor Author

@gpetruc, @arizzi do have any objects to sign this PR?

@fabiocos
Copy link
Contributor

fabiocos commented Jul 3, 2018

+1

@fabiocos
Copy link
Contributor

fabiocos commented Jul 3, 2018

merge

@cmsbuild cmsbuild merged commit f6cc561 into cms-sw:master Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants