Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show acquire() calls in the NVidia profiler #23731

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jul 2, 2018

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2018

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

HeterogeneousCore/CUDAServices

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28973/console Started: 2018/07/02 15:26

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2018

-1

Tested at: 037b133

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23731/28973/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

The relvals timed out after 2 hours.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2018

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@fwyzard fwyzard changed the title Show acquire() calls in the NVidia profile Show acquire() calls in the NVidia profiler Jul 3, 2018
@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 3, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28986/console Started: 2018/07/03 08:00

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23731/28986/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2899480
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2899288
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jul 3, 2018

+1

@cmsbuild cmsbuild merged commit 4e5b4a2 into cms-sw:master Jul 3, 2018
@fwyzard fwyzard deleted the NVProfilerService_show_acquire_pre6 branch July 5, 2018 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants