New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python2->3 remove keys() from len(dict.keys()) #23737
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23737/5406 |
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: CalibMuon/DTCalibration @kpedro88, @fabozzi, @pohsun, @monttj, @arizzi, @perrotta, @vanbesien, @cmsbuild, @GurpreetSinghChahal, @davidlange6, @smuzaffar, @Dr15Jones, @jfernan2, @cerminar, @slava77, @ggovi, @fabiocos, @prebello, @vazzolini, @kmaeshima, @arunhep, @dmitrijus, @franzoni, @gpetruc, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 based on tests-approved |
Comparison is ready Comparison Summary:
|
+1 |
+operations |
+1 |
+1 |
+1 for #23737 0140f52
|
@ggovi please check, I would like to move forward with this PR by today |
+1 technical update |
merge |
len(dict.keys()) will not work in python3 as keys() will be an iterator. Fortunately len(dict) is the same functionality.