Phase2-hgx128 Complete the SIM steps for HFNose #23794

bsunanda · 2018-07-13T20:31:35Z

Now one can run simulation in a geometry scenario with HFNose and can get the PCaloHit collection for HFNose

cmsbuild · 2018-07-13T20:33:03Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-07-13T20:37:01Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23794/5487

cmsbuild · 2018-07-13T20:37:19Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData
SimG4CMS/Calo
SimG4Core/Application
Validation/HGCalValidation

@andrius-k, @Dr15Jones, @kmaeshima, @schneiml, @ianna, @mdhildreth, @dmitrijus, @cmsbuild, @jfernan2, @kpedro88, @civanch can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @makortel, @rovere, @lgray, @cseez, @pfs, @kpedro88 this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

davidlange6 · 2018-07-13T20:42:50Z

please test

cmsbuild · 2018-07-13T20:45:00Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29115/console Started: 2018/07/13 22:45

cmsbuild · 2018-07-13T22:45:01Z

+1
Tested at: d1788c5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23794/29115/summary.html

cmsbuild · 2018-07-13T22:45:04Z

Comparison job queued.

cmsbuild · 2018-07-14T00:47:35Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23794/29115/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2887250
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2887058
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

kpedro88 · 2018-07-15T16:28:04Z

SimG4CMS/Calo/interface/HFNoseNumberingScheme.h

+#include "Geometry/HGCalCommonData/interface/HGCalDDDConstants.h"
+#include "Geometry/HGCalCommonData/interface/HGCalGeometryMode.h"
+
+#include "G4Step.hh"


is this include needed?

kpedro88 · 2018-07-15T16:30:29Z

SimG4CMS/Calo/src/HFNoseNumberingScheme.cc

+#endif
+  }
+#ifdef EDM_ML_DEBUG
+  edm::LogVerbatim("HGCSim") << "HGCalNumberingScheme::i/p " << layer << ":"


change "HGCSim", "HGCalNumberingScheme" to "HFNoseSim", "HFNoseNumberingScheme" to avoid confusion

kpedro88 · 2018-07-15T16:31:27Z

SimG4CMS/Calo/src/HFNoseSD.cc

+			    << "\n"
+			    << "**************************************************";
+#endif
+  edm::LogVerbatim("HGCSim") << "HFNoseSD:: Threshold for storing hits: " 


should these all be inside the EDM_ML_DEBUG ifdef?

I prefer to keep it out of EDM_ML_DEBUG

bsunanda · 2018-07-15T19:34:07Z

@cmsbuild Please test

cmsbuild · 2018-07-16T00:25:07Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23794/29124/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2892290
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2892098
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

kpedro88 · 2018-07-16T07:41:01Z

+upgrade

bsunanda · 2018-07-16T15:27:56Z

@ianna @civanch @dmitrijus Could you approve this PR so that we can go forward to complete Workflow with HFNose

ianna · 2018-07-17T17:34:30Z

+1

bsunanda · 2018-07-17T17:52:07Z

@civanch @dmitrijus Could you please sign this PR

civanch · 2018-07-17T18:39:02Z

+1

bsunanda · 2018-07-17T19:03:39Z

@fabiocos @dmitrijus I think only signature from DQM is missing. This has a small change in the validation code to test geometry of HFNose - could this be signed and merged urgently?

fabiocos · 2018-07-18T19:01:50Z

@jfernan2 could dqm please have a look?

jfernan2 · 2018-07-18T19:14:46Z

+1

…

________________________________________ From: Fabio Cossutti [notifications@github.com] Sent: 18 July 2018 21:01 To: cms-sw/cmssw Cc: Javier Fernandez Menendez; Mention Subject: Re: [cms-sw/cmssw] Phase2-hgx128 Complete the SIM steps for HFNose (#23794) @jfernan2<https://github.com/jfernan2> could dqm please have a look? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#23794 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AETJ6VHsvluKL82Bz985Gi_n6P-zF3yfks5uH4YigaJpZM4VPeIr>.

cmsbuild · 2018-07-18T19:15:06Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-07-18T19:47:31Z

+1

Complete the SIM steps for HFNose

d1788c5

cmsbuild added this to the CMSSW_10_2_X milestone Jul 13, 2018

cmsbuild added code-checks-pending comparison-pending dqm-pending geometry-pending orp-pending pending-signatures simulation-pending tests-pending upgrade-pending labels Jul 13, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 13, 2018

cmsbuild added tests-started and removed tests-pending labels Jul 13, 2018

cmsbuild added tests-approved and removed tests-started labels Jul 13, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jul 14, 2018

kpedro88 reviewed Jul 15, 2018

View reviewed changes

Take care of comments of Kevin

87f6da0

cmsbuild added tests-approved and removed tests-started labels Jul 15, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jul 16, 2018

cmsbuild added upgrade-approved and removed upgrade-pending labels Jul 16, 2018

smuzaffar modified the milestones: CMSSW_10_2_X, CMSSW_10_3_X Jul 17, 2018

cmsbuild added geometry-approved and removed geometry-pending labels Jul 17, 2018

cmsbuild added simulation-approved and removed simulation-pending labels Jul 17, 2018

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jul 18, 2018

cmsbuild added orp-approved and removed orp-pending labels Jul 18, 2018

cmsbuild merged commit 69137e8 into cms-sw:master Jul 18, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2-hgx128 Complete the SIM steps for HFNose #23794

Phase2-hgx128 Complete the SIM steps for HFNose #23794

bsunanda commented Jul 13, 2018

cmsbuild commented Jul 13, 2018

cmsbuild commented Jul 13, 2018

cmsbuild commented Jul 13, 2018

davidlange6 commented Jul 13, 2018

cmsbuild commented Jul 13, 2018 •

edited

cmsbuild commented Jul 13, 2018

cmsbuild commented Jul 13, 2018

cmsbuild commented Jul 14, 2018

kpedro88 Jul 15, 2018

kpedro88 Jul 15, 2018

kpedro88 Jul 15, 2018

bsunanda Jul 15, 2018

bsunanda commented Jul 15, 2018

cmsbuild commented Jul 16, 2018

kpedro88 commented Jul 16, 2018

bsunanda commented Jul 16, 2018

ianna commented Jul 17, 2018

bsunanda commented Jul 17, 2018

civanch commented Jul 17, 2018

bsunanda commented Jul 17, 2018

fabiocos commented Jul 18, 2018

jfernan2 commented Jul 18, 2018 via email

cmsbuild commented Jul 18, 2018

fabiocos commented Jul 18, 2018

Phase2-hgx128 Complete the SIM steps for HFNose #23794

Phase2-hgx128 Complete the SIM steps for HFNose #23794

Conversation

bsunanda commented Jul 13, 2018

cmsbuild commented Jul 13, 2018

cmsbuild commented Jul 13, 2018

cmsbuild commented Jul 13, 2018

davidlange6 commented Jul 13, 2018

cmsbuild commented Jul 13, 2018 • edited

cmsbuild commented Jul 13, 2018

cmsbuild commented Jul 13, 2018

cmsbuild commented Jul 14, 2018

kpedro88 Jul 15, 2018

Choose a reason for hiding this comment

kpedro88 Jul 15, 2018

Choose a reason for hiding this comment

kpedro88 Jul 15, 2018

Choose a reason for hiding this comment

bsunanda Jul 15, 2018

Choose a reason for hiding this comment

bsunanda commented Jul 15, 2018

cmsbuild commented Jul 16, 2018

kpedro88 commented Jul 16, 2018

bsunanda commented Jul 16, 2018

ianna commented Jul 17, 2018

bsunanda commented Jul 17, 2018

civanch commented Jul 17, 2018

bsunanda commented Jul 17, 2018

fabiocos commented Jul 18, 2018

jfernan2 commented Jul 18, 2018 via email

cmsbuild commented Jul 18, 2018

fabiocos commented Jul 18, 2018

cmsbuild commented Jul 13, 2018 •

edited