Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HCAL] single pion test update #23806

Merged
merged 3 commits into from
Jul 25, 2018

Conversation

abdoulline
Copy link

@abdoulline abdoulline commented Jul 17, 2018

Update of widely used private single-pion test (calorimetry scan)
Now published results look like that (comparing the most recent 10_2_X IB with 10_2_0_pre6):
https://cms-cpt-software.web.cern.ch/cms-cpt-software/General/Validation/SVSuite/HCAL/calo_scan_single_pi/10_X/10_2_0_pre6_vs_102X_SinglePi/

Also added: two profile and two 1D histos for HB/HE RecHits Chi2.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @abdoulline (Salavat Abdullin) for master.

It involves the following packages:

Validation/CaloTowers
Validation/HcalRecHits

@andrius-k, @kmaeshima, @schneiml, @dmitrijus, @cmsbuild, @jfernan2 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 17, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29135/console Started: 2018/07/17 10:17

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23806/29135/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2892290
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2892098
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 296.816 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 25202.0,... ): 11.416 KiB HLT/HCAL
  • DQMHistoSizes: changed ( 25202.0,... ): 11.416 KiB HcalRecHitsV/HcalRecHitTask
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4199b90 into cms-sw:master Jul 25, 2018
@abdoulline abdoulline deleted the single-pion-validation-update-102X branch May 13, 2019 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants