Print function migration for Utilities_StaticAnalyzers #23836
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23836/5531 |
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: Utilities/StaticAnalyzers @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| path = nx.shortest_path(G,tfunc,dataclassfunc) | ||
| for p in path: | ||
| print p+"; ", | ||
| print "' ", | ||
| print(p+"; ", end=' ') |
There was a problem hiding this comment.
What is the end= option? Presumably it is because of the ending comma? What is the comma actually doing?
There was a problem hiding this comment.
I did a google search and found the end= prevents a new line character to be added to the print. This is also what the , does in python 2. So everything is consistent.
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Using futurize -n -w --no-diffs -j 4 -f libfuturize.fixes.fix_print_with_import