Print function migration for SimCalorimetry_HGCalSimProducers

[davidlange6]

Using futurize -n -w --no-diffs -j 4 -f libfuturize.fixes.fix_print_with_import

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23853/5544

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

SimCalorimetry/HGCalSimProducers

@cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @makortel, @kpedro88, @lgray, @cseez, @pfs this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29206/console Started: 2018/07/19 15:00

[kpedro88]

Is it actually necessary to import from future? I thought print() was usable natively in python 2.7.

[davidlange6]

yes, it is needed

>> a = [1,2,3,4] >> print(a,"hi")

([1, 2, 3, 4], 'hi') vs

>> from __future__ import print_function >> print(a,"hi")

[1, 2, 3, 4] hi

…

On Jul 19, 2018, at 6:08 PM, Kevin Pedro ***@***.***> wrote: Is it actually necessary to import from future? I thought print() was usable natively in python 2.7. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[kpedro88]

Ah, the behavior is actually different. Good to know, thanks.

[cmsbuild]

-1

Tested at: 4743592

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23853/29206/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

The relvals timed out after 2 hours.

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[kpedro88]

please test

[kpedro88]

IB is broken, see #23873

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29272/console Started: 2018/07/20 21:59

[cmsbuild]

+1
Tested at: 4743592
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23853/29272/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23853/29272/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2889284
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2889092
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[civanch]

+1

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1