global chi2/ndf cut removed from isLooseTriggerMuon

[schhibra]

The chi2/ndf cut at HLT is found causing a drop in trigger efficiency in the endcaps for high-pt muons. The big is fixed by removing this cut completely from HLT. More details: https://indico.cern.ch/event/742890/contributions/3074437/attachments/1689747/2718508/20180718_PPDGenMeeting_1020pre4problem_schhibra.pdf

The muon selector, isLooseTrigeerMuon, is modified accordingly to be consistent with the changes.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23898/5597

[cmsbuild]

A new Pull Request was created by @schhibra for master.

It involves the following packages:

DataFormats/MuonReco

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @folguera, @abbiendi, @rovere, @jhgoh, @calderona, @HuguesBrun, @drkovalskyi, @trocino, @amagitte, @bachtis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[drkovalskyi]

We will need a back port for 10_2 as soon as possible.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29264/console Started: 2018/07/20 17:52

[cmsbuild]

+1
Tested at: 90f2cc0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23898/29264/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23898/29264/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2892290
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2892099
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[slava77]

@schhibra
please add a link to slides and some details in the PR description for self-documentation

[schhibra]

@slava77
Details added in the PR description.

[slava77]

Details added in the PR description.

thank you.

[slava77]

+1

for #23898 90f2cc0

• muon::isLooseTriggerMuon selector is updated, in line with the resolution of the issue of matching with large chi2.
• jenkins tests pass and comparisons with the baseline show differences only in the reco::Muon::selectors flag values corresponding to the isLooseTriggerMuon bit

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1