Make Ecal TimeBias correction to use a new GT. #2397

dmitrijus · 2014-02-11T12:47:35Z

Do not merge/build yet; this requires a new GT to work.

Some additional configuration files might also need to be changed in the next commit.

…levant configuration files. Whether time correction is applied now depends on which EcalTimeBiasCorrections record is used.

cmsbuild · 2014-02-11T12:47:51Z

A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_1_X.

Make Ecal TimeBias correction to use a new GT.

It involves the following packages:

Configuration/GlobalRuns
Configuration/StandardSequences
HLTrigger/Configuration
RecoLocalCalo/EcalRecProducers

@perrotta, @cmsbuild, @thspeer, @vlimant, @fwyzard, @franzoni, @Martin-Grunewald, @anton-a, @nclopezo, @slava77, @Degano, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

davidlange6 · 2014-02-11T13:08:05Z

Closing until a GT is in hand

rcastello · 2014-02-18T18:12:03Z

GTs available at #2517

cmsbuild · 2014-02-19T17:36:55Z

-1
When I ran the RelVals I found an error in the following worklfows:
101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log
----- Begin Fatal Exception 19-Feb-2014 18:24:22 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'local_digireco'
   [2] Calling event method for module EcalUncalibRecHitProducer/'ecalGlobalUncalibRecHit'
Exception Message:
No "EcalTimeBiasCorrectionsRcd" record found in the EventSetup.
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 19-Feb-2014 18:24:48 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module EcalUncalibRecHitProducer/'ecalGlobalUncalibRecHit'
Exception Message:
No "EcalTimeBiasCorrectionsRcd" record found in the EventSetup.
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

401.0 step1

runTheMatrix-results/401.0_TTbarNewMix+TTbarFSPU2+HARVESTFS/step1_TTbarNewMix+TTbarFSPU2+HARVESTFS.log
----- Begin Fatal Exception 19-Feb-2014 18:24:54 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module EcalUncalibRecHitProducer/'ecalGlobalUncalibRecHit'
Exception Message:
No "EcalTimeBiasCorrectionsRcd" record found in the EventSetup.
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
----- Begin Fatal Exception 19-Feb-2014 18:26:06 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing run: 165121 lumi: 62 event: 23609118
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module EcalUncalibRecHitProducer/'ecalGlobalUncalibRecHit'
Exception Message:
No "EcalTimeBiasCorrectionsRcd" record found in the EventSetup.
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log
----- Begin Fatal Exception 19-Feb-2014 18:26:16 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing run: 165121 lumi: 62 event: 23609118
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module EcalUncalibRecHitProducer/'ecalGlobalUncalibRecHit'
Exception Message:
No "EcalTimeBiasCorrectionsRcd" record found in the EventSetup.
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log
----- Begin Fatal Exception 19-Feb-2014 18:26:43 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing run: 191226 lumi: 398 event: 556818698
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module EcalUncalibRecHitProducer/'ecalGlobalUncalibRecHit'
Exception Message:
No "EcalTimeBiasCorrectionsRcd" record found in the EventSetup.
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log
----- Begin Fatal Exception 19-Feb-2014 18:28:24 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing run: 194533 lumi: 329 event: 461582793
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module EcalUncalibRecHitProducer/'ecalGlobalUncalibRecHit'
Exception Message:
No "EcalTimeBiasCorrectionsRcd" record found in the EventSetup.
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 19-Feb-2014 18:29:11 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module EcalUncalibRecHitProducer/'ecalGlobalUncalibRecHit'
Exception Message:
No "EcalTimeBiasCorrectionsRcd" record found in the EventSetup.
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log
----- Begin Fatal Exception 19-Feb-2014 18:35:32 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module EcalUncalibRecHitProducer/'ecalGlobalUncalibRecHit'
Exception Message:
No "EcalTimeBiasCorrectionsRcd" record found in the EventSetup.
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2397/236/summary.html

argiro · 2014-02-21T09:02:07Z

@davidlange6 , hi David, these errors occur even after integrating #2517 ?

davidlange6 · 2014-02-21T09:14:39Z

wrong David I think… but in general we need self contained pull requests.. so its better to get the GT and then make a pull request if the pull request doesn't work without the GT.

On Feb 21, 2014, at 10:02 AM, argiro notifications@github.com
wrote:

@davidlange6 , hi David, these errors occur even after integrating #2517 ?

—
Reply to this email directly or view it on GitHub.

davidlange6 · 2014-02-21T09:29:43Z

ah - its the right David (wishing that github sent you an email when you make a comment..)

I guess I should have left this closed until the GT was integrated -but now it is.. so will leave to DavidM/@ktf to comment

cmsbuild · 2014-02-21T09:55:41Z

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2397/255/summary.html

nclopezo · 2014-02-21T10:08:17Z

Hi,

The last tests were done with CMSSW_7_1_X_2014-02-21-0200, with includes #2517

davidlange6 · 2014-02-21T10:18:54Z

David - you mean, eg, the tests that just succeeded? (not the ones that failed two days ago when I re-opened the PR)

On Feb 21, 2014, at 11:08 AM, David Mendez notifications@github.com
wrote:

Hi,

The last tests were done with CMSSW_7_1_X_2014-02-21-0200, with includes #2517

—
Reply to this email directly or view it on GitHub.

nclopezo · 2014-02-21T10:27:34Z

I mean the last that just succeeded, this ones:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2397/255/summary.html

davidlange6 · 2014-02-25T10:37:48Z

+1 for operations (reco / hlt signatures needed still - not sure if there is an issue getting either of those - the changes are not so big)

perrotta · 2014-02-25T10:50:06Z

+1
(HLT related changes only consist in the removal of a few lines in a configuration used for mc customization, lines that were anyhow already commented out previously)

slava77 · 2014-02-26T14:37:11Z

working on it

slava77 · 2014-02-26T14:46:33Z

+1

for #2397 fbaaf87
based on jenkins

davidlange6 · 2014-02-27T10:37:19Z

@ktf - I +1-ed this for operations - but it seems not to have been taken.. this PR is otherwise signed, so can go into 71x

Martin-Grunewald · 2014-03-04T06:16:19Z

Why is this PR not being integrated?

ktf · 2014-03-04T08:13:01Z

@davidlange6 +1 needs to be on a standalone line. I missed this. Will merge now.

HLT -- Make Ecal TimeBias correction to use a new GT.

Dmitrijus Bugelskis added 2 commits February 11, 2014 13:07

Use CondDB to fetch time bias corrections.

107482e

Some additional configuration files might also need to be changed in the next commit.

Remove doE(E|B)timeCorrection from EcalUncalibRecHit producers and re…

fbaaf87

…levant configuration files. Whether time correction is applied now depends on which EcalTimeBiasCorrections record is used.

davidlange6 closed this Feb 11, 2014

rcastello mentioned this pull request Feb 18, 2014

Updated GTs for 710_pre3 #2517

Merged

davidlange6 reopened this Feb 19, 2014

dmitrijus added hlt-pending labels Feb 19, 2014

dmitrijus added hlt-pending labels Feb 21, 2014

nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014

dmitrijus added hlt-approved labels Feb 25, 2014

dmitrijus added hlt-approved labels Feb 26, 2014

ktf added a commit that referenced this pull request Mar 4, 2014

Merge pull request #2397 from dmitrijus/timebias-use-conditions

eb873dc

HLT -- Make Ecal TimeBias correction to use a new GT.

ktf merged commit eb873dc into cms-sw:CMSSW_7_1_X Mar 4, 2014

nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make Ecal TimeBias correction to use a new GT. #2397

Make Ecal TimeBias correction to use a new GT. #2397

dmitrijus commented Feb 11, 2014

cmsbuild commented Feb 11, 2014

davidlange6 commented Feb 11, 2014

rcastello commented Feb 18, 2014

cmsbuild commented Feb 19, 2014

argiro commented Feb 21, 2014

davidlange6 commented Feb 21, 2014

davidlange6 commented Feb 21, 2014

cmsbuild commented Feb 21, 2014

nclopezo commented Feb 21, 2014

davidlange6 commented Feb 21, 2014

nclopezo commented Feb 21, 2014

davidlange6 commented Feb 25, 2014

perrotta commented Feb 25, 2014

slava77 commented Feb 26, 2014

slava77 commented Feb 26, 2014

davidlange6 commented Feb 27, 2014

Martin-Grunewald commented Mar 4, 2014

ktf commented Mar 4, 2014

Make Ecal TimeBias correction to use a new GT. #2397

Make Ecal TimeBias correction to use a new GT. #2397

Conversation

dmitrijus commented Feb 11, 2014

cmsbuild commented Feb 11, 2014

davidlange6 commented Feb 11, 2014

rcastello commented Feb 18, 2014

cmsbuild commented Feb 19, 2014

argiro commented Feb 21, 2014

davidlange6 commented Feb 21, 2014

davidlange6 commented Feb 21, 2014

cmsbuild commented Feb 21, 2014

nclopezo commented Feb 21, 2014

davidlange6 commented Feb 21, 2014

nclopezo commented Feb 21, 2014

davidlange6 commented Feb 25, 2014

perrotta commented Feb 25, 2014

slava77 commented Feb 26, 2014

slava77 commented Feb 26, 2014

davidlange6 commented Feb 27, 2014

Martin-Grunewald commented Mar 4, 2014

ktf commented Mar 4, 2014