Fix bug in FormulaEvaluator involving parenthesis and precedence order

[Dr15Jones]

A sub-expression involving a parenthesis was not using the top node as the representation for the expression. That mixed with precedence order fixing resulted in part of the expression being lost.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24049/5736

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CommonTools/Utils

@perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29459/console Started: 2018/07/25 21:38

[cmsbuild]

+1
Tested at: 611a792
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24049/29459/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24049/29459/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 616 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2889585
• DQMHistoTests: Total failures: 1749
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2887646
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[slava77]

Changes vary somewhat by the type of processing:

• almost no change in 2017 MC re-miniAOD
• somewhat significant changes in 2016 MC re-miniAOD

in 2016 reminiAOD ZEE wf 1325.5


not much visible effect for pt >~20 GeV

Changes are a bit mixed in data

• 136.7611 wf 2016E JetHT
  
• 136.8311 wf 2017F JetHT
  

So, it's somewhat up and down depending on the JECs.

Anyways, perhaps more interesting illustrations were posted in #24023 e.g. http://uaf-10.t2.ucsd.edu/%7Enamin/dump/issue_24023/plot_unclipped.png

[slava77]

+1

for #24049 611a792

• code change is in line with the description; there are also quite a bit of debug functionality added. The problematic cases were added to the unit tests.
• jenkins tests pass and comparisons with the baseline show changes in miniAOD variables related to jets

[fabiocos]

+1

[fabiocos]

merge