Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMTF emulate directly from unpacked CPPF digis - 10_2_X backport #24106

Merged
merged 6 commits into from Aug 17, 2018

Conversation

abrinke1
Copy link
Contributor

Backport of #23747 for DQM, forward port of #23919

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 27, 2018

A new Pull Request was created by @abrinke1 for CMSSW_10_2_X.

It involves the following packages:

DQM/L1TMonitor
DataFormats/L1TMuon
EventFilter/L1TRawToDigi
L1Trigger/L1TMuon
L1Trigger/L1TMuonEndCap

@cmsbuild, @andrius-k, @kmaeshima, @schneiml, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 27, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29527/console Started: 2018/07/27 10:47

@thomreis
Copy link
Contributor

backport of #23747

@thomreis
Copy link
Contributor

Hi @abrinke1
thanks for making this one. We still need a PR to the master with the last commit with the DQM configuration change.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24106/29527/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2892296
  • DQMHistoTests: Total failures: 49
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2892057
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@thomreis
Copy link
Contributor

+1

@andrius-k
Copy link

+1
backport of #23747 and #24120

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Aug 7, 2018

@thomreis as far as I understand, this PR does not modify the event content, but it affects the physics output of the simulation as well, do you confirm?

@fabiocos
Copy link
Contributor

fabiocos commented Aug 7, 2018

@thomreis actually it should not affect MC according to the discussion in master, could you please confirm it?

@abrinke1
Copy link
Contributor Author

abrinke1 commented Aug 7, 2018

@fabiocos you are correct: this update does not affect anything in the MC.

@thomreis
Copy link
Contributor

thomreis commented Aug 8, 2018

Hi @fabiocos
@abrinke1 is one of the experts of the EMTF and his comment is correct.

@fabiocos
Copy link
Contributor

fabiocos commented Aug 8, 2018

@abrinke1 @thomreis perfect, thank you

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit aa0f8ca into cms-sw:CMSSW_10_2_X Aug 17, 2018
@abrinke1 abrinke1 deleted the EMTF_PR_10_2_0_emul_from_CPPF branch September 18, 2018 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants