Addition of code for the "jet toolbox"

[jstupak]

Addition of code for gluon tagging, pileup jet ID, Nsubjettiness, and QJets volatility. This code will be used as part of the "jet toolbox."

[cmsbuild]

A new Pull Request was created by @jstupak for CMSSW_7_1_X.

Addition of code for the "jet toolbox"

It involves the following packages:

RecoJets/JetAlgorithms
RecoJets/JetProducers

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@yslai, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[rappoccio]

We cannot have RecoJets depending on PatCandidates.

[rappoccio]

Hi, Guys,

Unfortunately, this violates a large number of CMSSW rules and coding practices. Since there are so many, I will comment on individual lines in addition to this overall comment.

1. RecoJets cannot depend on PAT objects at all. Please remove all references of pat::Jet from these objects if you want them in the Reco domain.
2. We can't have a bunch of histogramming tools placed into JetAlgorithms.
3. The QGMLPCalculator data member "corrections" cannot be a string-based map.
4. We cannot have 90 text files dumped into the JetAlgorithms or JetProducers package.

It goes without saying that the right thing to do here is to get a proper CondDB implementation of the XML files instead of dropping the text files into the reco packages. This isn't infinite work, so there's no particular reason we can't just do it.

In addition to incorrect coding procedures, there are also a number of things wrong:

• This backs out the kt6 ---> fixed grid rho transition so that needs to be fixed also
• I'm not sure why you're recomputing rho to begin with in the QG tagger

I will comment on the individual lines for clarity.

[rappoccio]

Keeping this as a map of products with strings as the key needs to be changed, this is far too slow for a reco package.

[anton-a]

@jstupak - if part of this code is moved to #2429 then you have to close #2414 and make a new request when ready

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2414/251/summary.html