Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T muon offline DQM Fix dPhi calculation - 102x #24239

Conversation

thomreis
Copy link
Contributor

@thomreis thomreis commented Aug 8, 2018

backport of #24238

Fix the dPhi calculation in the L1T muon offline DQM tag and probe code to have a proper wrap around.
Also adds a currently empty harvesting sequence to match setup of the currently used special ones for EGamma and SingleMuon datasets.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2018

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_10_2_X.

It involves the following packages:

DQMOffline/L1Trigger

@cmsbuild, @andrius-k, @kmaeshima, @schneiml, @nsmith-, @rekovic, @jfernan2, @thomreis can you please review it and eventually sign? Thanks.
@kreczko, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor Author

thomreis commented Aug 8, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29730/console Started: 2018/08/08 17:48

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24239/29730/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2892884
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2892693
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@thomreis
Copy link
Contributor Author

thomreis commented Aug 8, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 14e2a7a into cms-sw:CMSSW_10_2_X Sep 11, 2018
@thomreis thomreis deleted the l1t_dqm_offline_muon_dphi_wrap_around_102x branch August 20, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants