Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to New Random Service Interface #2436

Merged
merged 1 commit into from Feb 14, 2014

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Feb 12, 2014

Migrate to the new random number service interface
designed for multithreaded execution.Also remove
a potential memory leak from TxCalculator. Note that
neither of the two classes modified is used or referenced
by anything in CMSSW.

Migrate to the new random number service interface
designed for multithreaded execution.Also remove
a potential memory leak from TxCalculator. Note that
neither of the two classes modified is used or referenced
by anything in CMSSW.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_1_X.

Migrate to New Random Service Interface

It involves the following packages:

RecoHI/HiEgammaAlgos
RecoJets/FFTJetProducers

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@TaiSakuma, @jazzitup, @yenjie, @kurtejung, @mandrenguyen, @richard-cms, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Feb 14, 2014

+1

for #2436 edf3874
based on

  • jenkins and
  • a private test of an HI wflow (can't say if it actually touched the code in question) CMSSW_7_1_X_2014-02-12-1400/sign308

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Feb 14, 2014
Multithreading fixes -- Migrate to New Random Service Interface
@ktf ktf merged commit 668322a into cms-sw:CMSSW_7_1_X Feb 14, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
@wddgit wddgit deleted the migrateToNewRandomServiceInterface2 branch April 25, 2014 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants