Make L1T object comparison fillDescriptions compatible with ConfDB parsing

[thomreis]

In order to have the framework modules appear in the ConfDB GUI it is needed to replace object comparison and filter fillDescriptions addDefault with addWithDefaultLabel.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24372/6138

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24372/6138/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24372/6138/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24372/6139

[cmsbuild]

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

L1Trigger/L1TCommon

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29996/console Started: 2018/08/23 11:35

[cmsbuild]

+1
Tested at: d5298e1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24372/29996/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24372/6141

[cmsbuild]

Pull request #24372 was updated. @cmsbuild, @Martin-Grunewald, @silviodonato, @nsmith-, @rekovic, @thomreis, @fwyzard can you please check and sign again.

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30006/console Started: 2018/08/23 15:16

[cmsbuild]

+1
Tested at: df78752
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24372/30006/summary.html

[cmsbuild]

Comparison job queued.

[Martin-Grunewald]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24372/30006/summary.html

There are some workflows for which there are errors in the baseline:
4.22 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

• You potentially added 776 lines to the logs
• Reco comparison results: 2297 differences found in the comparisons
• DQMHistoTests: Total files compared: 30
• DQMHistoTests: Total histograms compared: 2951098
• DQMHistoTests: Total failures: 11863
• DQMHistoTests: Total nulls: 9
• DQMHistoTests: Total successes: 2939045
• DQMHistoTests: Total skipped: 181
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 126 log files, 14 edm output root files, 30 DQM output files

[thomreis]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1