Run2-hcx182 Take care of analyzer checks in PR #24367

[bsunanda]

No description provided.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24384/6157

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/CaloTopology
RecoLocalCalo/CaloTowersCreator

@perrotta, @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30048/console Started: 2018/08/24 20:50

[cmsbuild]

+1
Tested at: 0ffe89c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24384/30048/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24384/30048/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2987459
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2987267
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[ianna]

+1

[perrotta]

• What is CaloTowersReCreator::produce actually producing? IOW, why CaloTowersReCreator is a edm::stream::EDProducer?
• Is "algo_" thread safe as such?
• Is CaloTowersReCreator ever used or needed? Why not simply remove the whole class?
• Is RecoLocalCalo/CaloTowersCreator/python/calotowerremaker_cfi.py needed, given the fillDescription in the class? It is never used, in fact

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30140/console Started: 2018/08/30 07:17

[cmsbuild]

+1
Tested at: 52538f9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24384/30140/summary.html

[cmsbuild]

Comparison job queued.

[ianna]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24384/30140/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3143879
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3143679
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[perrotta]

+1

• It fixes a few issues reported by the static analyzer
• Jenkins tests pass with no differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1