Phase2-hgx146 Add a new method for HGCalGeometry and add a test for corners

[bsunanda]

No description provided.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24409/6214

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData
Geometry/HGCalGeometry

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30131/console Started: 2018/08/29 18:44

[cmsbuild]

-1

Tested at: bf10fec

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24409/30131/summary.html

I found follow errors while testing this PR

Failed tests: Build HeaderConsistency

• Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-08-28-2300/src/L1Trigger/L1THGCal/plugins/geometries/HGCalTriggerGeometryV9Imp1.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-08-28-2300/src/L1Trigger/L1THGCal/plugins/geometries/NullGeometry.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-08-28-2300/src/L1Trigger/L1THGCal/plugins/geometries/HGCalTriggerGeometryImp1.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-08-28-2300/src/L1Trigger/L1THGCal/plugins/geometries/HGCalTriggerGeometryHexImp1.cc 
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-08-28-2300/src/L1Trigger/L1THGCal/plugins/geometries/HGCalTriggerGeometryV9Imp1.cc: In member function 'unsigned int HGCalTriggerGeometryV9Imp1::packIetaIphi(unsigned int, unsigned int) const':
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-08-28-2300/src/L1Trigger/L1THGCal/plugins/geometries/HGCalTriggerGeometryV9Imp1.cc:872:52: error: 'kHGCalEtaMask' is not a member of 'HGCScintillatorDetId'
     packed_value |= ((ieta & HGCScintillatorDetId::kHGCalEtaMask) << HGCScintillatorDetId::kHGCalEtaOffset);
                                                    ^~~~~~~~~~~~~
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-08-28-2300/src/L1Trigger/L1THGCal/plugins/geometries/HGCalTriggerGeometryV9Imp1.cc:872:92: error: 'kHGCalEtaOffset' is not a member of 'HGCScintillatorDetId'
     packed_value |= ((ieta & HGCScintillatorDetId::kHGCalEtaMask) << HGCScintillatorDetId::kHGCalEtaOffset);
                                                                                            ^~~~~~~~~~~~~~~


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30143/console Started: 2018/08/30 11:26

[cmsbuild]

+1
Tested at: bf10fec
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24409/30143/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24409/30143/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3143879
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3143681
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[kpedro88]

+upgrade

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[bsunanda]

@fabiocos @kpedro88 Can this PR be merged. This helps the next PR which can reduce memory usage by Fireworks

[fabiocos]

+1