Use new C++ abilities in FWCore/SOA #24427

Dr15Jones · 2018-08-31T15:56:00Z

Use C++17 constructs to improve the code.

cmsbuild · 2018-08-31T15:56:18Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-08-31T15:58:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24427/6249

cmsbuild · 2018-08-31T15:58:27Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/SOA

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2018-08-31T15:59:13Z

please test

Dr15Jones · 2018-08-31T15:59:17Z

+1

cmsbuild · 2018-08-31T15:59:32Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30179/console Started: 2018/08/31 18:00

cmsbuild · 2018-08-31T15:59:33Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

makortel · 2018-08-31T16:15:39Z

FWCore/SOA/interface/Table.h

+      if constexpr(sizeof...(CArgs)==0) {
+        CtrFillerFromAOS::fill(m_values,iContainer);
+      } else {
+      CtrFillerFromContainers::fill(m_values,iContainer,std::forward<CArgs>(iArgs)...);


Should this line be indented?

Thanks for the catch

Using fold expression to iterate through the elements may allow better optimization by the compiler and fewer template functions to be created.

cmsbuild · 2018-08-31T21:59:33Z

+1
Tested at: ff74186
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24427/30184/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
edb9f98
b31d805
af20b1d
19ae827
111cd66
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24427/30184/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24427/30184/git-merge-result

cmsbuild · 2018-08-31T21:59:36Z

Comparison job queued.

cmsbuild · 2018-08-31T23:17:14Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24427/30184/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3143879
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3143678
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

kpedro88 · 2018-09-01T22:17:05Z

please test

cmsbuild · 2018-09-01T22:17:26Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30204/console Started: 2018/09/02 00:19

cmsbuild · 2018-09-02T00:47:31Z

+1
Tested at: ff74186
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24427/30204/summary.html

cmsbuild · 2018-09-02T00:47:34Z

Comparison job queued.

cmsbuild · 2018-09-02T02:24:06Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24427/30204/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3143879
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3143680
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

Dr15Jones · 2018-09-04T13:18:17Z

@fabiocos @kpedro88 ping

fabiocos · 2018-09-06T08:30:50Z

+1

Dr15Jones added 2 commits August 31, 2018 10:54

Avoid using a function local static

17cc5ed

Simplified declaration of return type

8176c42

cmsbuild added this to the CMSSW_10_3_X milestone Aug 31, 2018

cmsbuild added code-checks-pending comparison-pending core-pending orp-pending pending-signatures tests-pending labels Aug 31, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 31, 2018

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Aug 31, 2018

cmsbuild added tests-started and removed tests-pending labels Aug 31, 2018

makortel reviewed Aug 31, 2018

View reviewed changes

Use fold expression instead of template recursion

ff74186

Using fold expression to iterate through the elements may allow better optimization by the compiler and fewer template functions to be created.

Dr15Jones force-pushed the newCppFWCoreSOA branch from 6479a11 to ff74186 Compare August 31, 2018 18:45

cmsbuild removed code-checks-approved core-approved fully-signed labels Aug 31, 2018

cmsbuild added tests-started and removed tests-pending labels Aug 31, 2018

cmsbuild added tests-approved and removed tests-started labels Aug 31, 2018

cmsbuild added comparison-available and removed comparison-pending labels Aug 31, 2018

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Sep 1, 2018

cmsbuild added tests-started and removed tests-pending labels Sep 1, 2018

cmsbuild added tests-approved and removed tests-started labels Sep 2, 2018

cmsbuild added comparison-available and removed comparison-pending labels Sep 2, 2018

cmsbuild added orp-approved and removed orp-pending labels Sep 6, 2018

cmsbuild merged commit 07a24e8 into cms-sw:master Sep 6, 2018

Dr15Jones deleted the newCppFWCoreSOA branch September 19, 2018 19:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use new C++ abilities in FWCore/SOA #24427

Use new C++ abilities in FWCore/SOA #24427

Dr15Jones commented Aug 31, 2018

cmsbuild commented Aug 31, 2018

cmsbuild commented Aug 31, 2018

cmsbuild commented Aug 31, 2018

Dr15Jones commented Aug 31, 2018

Dr15Jones commented Aug 31, 2018

cmsbuild commented Aug 31, 2018 •

edited

cmsbuild commented Aug 31, 2018

makortel Aug 31, 2018

Dr15Jones Aug 31, 2018

Dr15Jones Aug 31, 2018

cmsbuild commented Aug 31, 2018

cmsbuild commented Aug 31, 2018

cmsbuild commented Aug 31, 2018

kpedro88 commented Sep 1, 2018

cmsbuild commented Sep 1, 2018 •

edited

cmsbuild commented Sep 2, 2018

cmsbuild commented Sep 2, 2018

cmsbuild commented Sep 2, 2018

Dr15Jones commented Sep 4, 2018

fabiocos commented Sep 6, 2018

Use new C++ abilities in FWCore/SOA #24427

Use new C++ abilities in FWCore/SOA #24427

Conversation

Dr15Jones commented Aug 31, 2018

cmsbuild commented Aug 31, 2018

cmsbuild commented Aug 31, 2018

cmsbuild commented Aug 31, 2018

Dr15Jones commented Aug 31, 2018

Dr15Jones commented Aug 31, 2018

cmsbuild commented Aug 31, 2018 • edited

cmsbuild commented Aug 31, 2018

makortel Aug 31, 2018

Choose a reason for hiding this comment

Dr15Jones Aug 31, 2018

Choose a reason for hiding this comment

Dr15Jones Aug 31, 2018

Choose a reason for hiding this comment

cmsbuild commented Aug 31, 2018

cmsbuild commented Aug 31, 2018

cmsbuild commented Aug 31, 2018

kpedro88 commented Sep 1, 2018

cmsbuild commented Sep 1, 2018 • edited

cmsbuild commented Sep 2, 2018

cmsbuild commented Sep 2, 2018

cmsbuild commented Sep 2, 2018

Dr15Jones commented Sep 4, 2018

fabiocos commented Sep 6, 2018

cmsbuild commented Aug 31, 2018 •

edited

cmsbuild commented Sep 1, 2018 •

edited