New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SiPixelQuality PCL bug fix #24439
SiPixelQuality PCL bug fix #24439
Conversation
…ast IOV's payload; make PROMPT pixel quality plot the same as PERMANENT BAD plot when the whole run is low statistics
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24439/6271 |
A new Pull Request was created by @tocheng (Tongguang) for master. It involves the following packages: CalibTracker/SiPixelQuality @arunhep, @tocheng, @cmsbuild, @franzoni, @pohsun, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Hello,
the PR is to fix a simple mistake in the SiPixelQuality PCL harvester where occasionally the payload is mistakenly treated the same as payload in the last IOV and not appended to the pixel quality tag.
One or two IOVs are occasionally missed in the payload for prompt reco, making the improvement due to lumi based SiPixelQuality tag sub-optimal.
On the other hand, the DQM plots produced from the harvester are not effected.
It also fixes the DQM plot for the pixel quality used in prompt reconstruction during a low statistics run. Now if the run is low statistics for pixel, such as cosmic run, DQM plot for prompt reconstruction will be corrected filled instead of empty.