Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "DD: Current Namespace is a Singleton, so make it one" #24464

Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Sep 4, 2018

Reverts #24401

Fix for CLANG IBs failures:

%MSG-e Specific:  OscarMTProducer:g4SimHits@beginRun 01-Sep-2018 07:18:26 CEST  Run: 1
Could not process q-name of a DDLogicalPart, reason:
DDLogicalPart-name "RT1C" matching regex "RT1C" has been found at least in following namespaces:
rpcf GLOBAL 
Qualify the name with a regexp for the namespace, i.e ".*:name-regexp" !
SpecPar selection is:
//RT1C

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2018

@ianna
Copy link
Contributor Author

ianna commented Sep 4, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30256/console Started: 2018/09/04 17:51

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2018

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/Core
DetectorDescription/Parser
Geometry/EcalCommonData
Geometry/EcalTestBeam
Geometry/HGCalCommonData
Geometry/HcalAlgo
Geometry/HcalTestBeamData
Geometry/MTCCTrackerCommonData
Geometry/MuonCommonData
Geometry/TrackerCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @VinInn, @ghugo83, @ptcox, @ebrondol, @argiro, @venturia this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24464/30256/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3143879
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3143681
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Sep 5, 2018

+upgrade

@ianna
Copy link
Contributor Author

ianna commented Sep 5, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@ianna
Copy link
Contributor Author

ianna commented Sep 5, 2018

@fabiocos - please take it for pre3 if it's not too late. It should fix the CLANG IBs failures. Thanks.

@fabiocos
Copy link
Contributor

fabiocos commented Sep 6, 2018

+1

@cmsbuild cmsbuild merged commit 45b8082 into cms-sw:master Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants