New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FastSim: make two parameters of the KineParticleFilter configurable #24473
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24473/6319 |
A new Pull Request was created by @beaudett (Florian Beaudette) for master. It involves the following packages: FastSimulation/Event @cmsbuild, @ssekmen, @lveldere, @mdhildreth, @civanch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@ssekmen could you please review this PR? |
@fabiocos, thanks for reminding. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR aims at removing two hard-coded parameters related to the geometry of the detector in the particle filter of the FastSim. (The particle filter is used to select the generated particles that are in the acceptance of the detector)
Thus, it will be possible to use the same facility for the upgrade studies. At the moment, the FSimEvent, which uses this KineParticleFilter, is used in the HGCAL ntuplizer.
I performed a validation using the 250402.0 workflow from runTheMatrix (ttbar events with premixing). To do so, I checked the generalTracks. Indeed, in the FastSim the tracks are derived from the MC tracks, therefore if a different set of generated particles selected, it should reflect in the collection of tracks.
I find that the number of tracks and their pT spectrum are strictly identical in the two cases.