Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastSim: make two parameters of the KineParticleFilter configurable #24473

Merged
merged 1 commit into from Sep 13, 2018

Conversation

beaudett
Copy link
Contributor

@beaudett beaudett commented Sep 5, 2018

This PR aims at removing two hard-coded parameters related to the geometry of the detector in the particle filter of the FastSim. (The particle filter is used to select the generated particles that are in the acceptance of the detector)
Thus, it will be possible to use the same facility for the upgrade studies. At the moment, the FSimEvent, which uses this KineParticleFilter, is used in the HGCAL ntuplizer.

I performed a validation using the 250402.0 workflow from runTheMatrix (ttbar events with premixing). To do so, I checked the generalTracks. Indeed, in the FastSim the tracks are derived from the MC tracks, therefore if a different set of generated particles selected, it should reflect in the collection of tracks.

I find that the number of tracks and their pT spectrum are strictly identical in the two cases.
canvas_1_new
canvas_1_default

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2018

A new Pull Request was created by @beaudett (Florian Beaudette) for master.

It involves the following packages:

FastSimulation/Event

@cmsbuild, @ssekmen, @lveldere, @mdhildreth, @civanch can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ssekmen
Copy link
Contributor

ssekmen commented Sep 5, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30278/console Started: 2018/09/05 22:39

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24473/30278/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3143975
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3143775
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

@ssekmen could you please review this PR?

@ssekmen
Copy link
Contributor

ssekmen commented Sep 13, 2018

@fabiocos, thanks for reminding.

@ssekmen
Copy link
Contributor

ssekmen commented Sep 13, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants