Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T DQM - Add new unpackers for HI run configuration - 102x #24500

Merged
merged 1 commit into from Sep 11, 2018

Conversation

thomreis
Copy link
Contributor

Backport of #24499

Add missing unpacker raw data input collection changes for HI run configuration to the L1T online DQM configurations.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 11, 2018

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_10_2_X.

It involves the following packages:

DQM/Integration

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@makortel, @threus, @batinkov this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 11, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30325/console Started: 2018/09/11 11:07

@thomreis
Copy link
Contributor Author

type bugfix

for HI

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@fabiocos
Copy link
Contributor

@thomreis sorry, is this relevant for the test of next week? To my knowledge the HI data taking will be made using 10_3_X...

@thomreis
Copy link
Contributor Author

@fabiocos yesterday there were tests on the playback system with 10_2 that failed. @threus requested fixes for 10_2 and master.

@fabiocos
Copy link
Contributor

@thomeis sorry, I am confused by the title of this PR, what is HI specific here?

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24500/30325/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2985426
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2985233
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@thomreis
Copy link
Contributor Author

The configuration is only used if process.runType.hi_run is true.

@threus
Copy link
Contributor

threus commented Sep 11, 2018

@fabiocos it's the names of FED collections used by the various modules, to be used in the online L1T DQM clients only during the HI run. As 10_2_X will be used during the TS2 test, I asked @thomreis to also make a backport to 10_2_X that we'll pick up.

@fabiocos
Copy link
Contributor

@thomreis @threus ok, thank you for the clarification. So indeed this should be part of the 10_2_X backport

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 162dcc5 into cms-sw:CMSSW_10_2_X Sep 11, 2018
@thomreis thomreis deleted the l1t_dqm_hi_conf_fix_102x branch August 20, 2020 08:08
fwyzard pushed a commit to cms-patatrack/cmssw that referenced this pull request Oct 8, 2020
L1T DQM - Add new unpackers for HI run configuration - 102x
fwyzard pushed a commit to cms-patatrack/cmssw that referenced this pull request Oct 19, 2020
L1T DQM - Add new unpackers for HI run configuration - 102x
fwyzard pushed a commit to cms-patatrack/cmssw that referenced this pull request Oct 20, 2020
L1T DQM - Add new unpackers for HI run configuration - 102x
fwyzard pushed a commit to cms-patatrack/cmssw that referenced this pull request Oct 23, 2020
L1T DQM - Add new unpackers for HI run configuration - 102x
fwyzard pushed a commit to cms-patatrack/cmssw that referenced this pull request Nov 6, 2020
L1T DQM - Add new unpackers for HI run configuration - 102x
fwyzard pushed a commit to cms-patatrack/cmssw that referenced this pull request Nov 16, 2020
L1T DQM - Add new unpackers for HI run configuration - 102x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants