Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "L1T offline emulator DQM config upgrades - 102x" #24552

Merged
merged 1 commit into from
Sep 15, 2018

Conversation

fabiocos
Copy link
Contributor

Reverts #24291

This PR assumes the output of the L1 simGmtStage2Digis available on input, but this is not true in the standard repacking. Pending a properly tested solution, this update is temporarily reverted.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_10_2_X.

It involves the following packages:

DQMOffline/L1Trigger

@cmsbuild, @andrius-k, @kmaeshima, @schneiml, @nsmith-, @rekovic, @jfernan2, @thomreis can you please review it and eventually sign? Thanks.
@kreczko, @thomreis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test workflow 136.867

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 15, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30429/console Started: 2018/09/15 08:08

@fabiocos
Copy link
Contributor Author

see #24551 for details of the problem

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24552/30429/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24552/136.867_RunSingleMu2018B+RunSingleMu2018B+HLTDR2_2018+RECODR2_2018reHLT_skimSingleMu_Prompt_Lumi+HARVEST2018_L1TMuDQM

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2985018
  • DQMHistoTests: Total failures: 25
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2984803
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -37817.95 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 1330.0,... ): -2622.360 KiB L1TEMU/L1TStage2CaloLayer2
  • DQMHistoSizes: changed ( 1330.0 ): -878.957 KiB L1TEMU/L1TObjects
  • DQMHistoSizes: changed ( 1330.0,... ): 9.366 KiB L1T/L1TStage2EMTF
  • DQMHistoSizes: changed ( 1330.0,... ): -2.121 KiB L1TEMU/EventInfo
  • DQMHistoSizes: changed ( 1330.0,... ): -1.309 KiB L1TEMU/L1TdeStage2uGMT
  • DQMHistoSizes: changed ( 1330.0,... ): -0.376 KiB L1TEMU/L1TdeStage2uGT
  • DQMHistoSizes: changed ( 1330.0,... ): -0.184 KiB L1TEMU/L1TdeStage2BMTF
  • DQMHistoSizes: changed ( 1330.0,... ): -0.117 KiB L1TEMU/L1TdeStage2EMTF
  • DQMHistoSizes: changed ( 1330.0,... ): -0.117 KiB L1TEMU/L1TdeStage2OMTF
  • DQMHistoSizes: changed ( 136.731,... ): -2624.466 KiB L1TEMU/L1TStage2CaloLayer2
  • DQMHistoSizes: changed ( 136.85 ): ...
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@fabiocos
Copy link
Contributor Author

+1

@fabiocos
Copy link
Contributor Author

merge

@thomreis
Copy link
Contributor

+1
post-merge

@andrius-k
Copy link

+1

Signing for the sake of completeness.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will be automatically merged.

@smuzaffar smuzaffar deleted the revert-24291-offline_dqm_l1temu_config_102x branch December 10, 2018 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants