-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TrackHitsFilter and TrackHitsFilterFactory as unused #24645
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24645/6551 |
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: RecoPixelVertexing/PixelLowPtUtilities @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Indeed TrackHitsFilter and TrackHitsFilterFactory do not look as being ever used in CMSSW. |
thanks, I've just checked w/ pixel local reco, too |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Title says it all. I noticed this while going through all plugin factories for #12853.
Tested in 10_3_0_pre4, no changes expected.
@Dr15Jones