Prepare RPCConeBuilder for concurrent IOVs #24658
Conversation
Changed produce return value from shared_ptr to unique_ptr. Replaced non-const member data with stack variables. Removed callbacks that performed EventSetup gets and just do that action in produce directly. I couldn't resist cleaning this up. Deleted commented out code, code that does nothing, fixed indentation and blank space, upgraded to use some C++11 ranged for loops, removed unneeded includes, deleted trailing space ...
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24658/6578 |
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: L1Trigger/RPCTrigger @nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Changed produce return value from shared_ptr to
unique_ptr. Replaced non-const member data with
stack variables. Removed callbacks that performed
EventSetup gets and just do that action in produce
directly.
Tested by running step 2 of runTheMatrix.py and printing
out the contents of the produced object and comparing
with and without the changes. There were no differences.
I couldn't resist cleaning this up. Deleted commented
out code, code that does nothing, fixed indentation and
blank space, upgraded to use some C++11 ranged for loops,
removed unneeded includes, deleted trailing space ...