Rename MTDModuleNumbering plugin to avoid duplicates #24680

perrotta · 2018-09-27T09:13:05Z

Meant to fix the issue reported by the Duplicate Dictionaries check in the jenkins tests and discussed in #24285 (review)

cmsbuild · 2018-09-27T09:13:25Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-09-27T09:13:59Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24680/6614

cmsbuild · 2018-09-27T09:14:20Z

A new Pull Request was created by @perrotta for master.

It involves the following packages:

Geometry/MTDNumberingBuilder

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

perrotta · 2018-09-27T09:16:44Z

type bug fix

perrotta · 2018-09-27T09:17:05Z

please test

cmsbuild · 2018-09-27T09:17:24Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30684/console Started: 2018/09/27 11:18

cmsbuild · 2018-09-27T11:38:28Z

-1

Tested at: 53c81cf

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24680/30684/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake2 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --fileout file:RelVal_Raw_Fake2_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Thu Sep 27 13:10:42 2018-date Thu Sep 27 13:05:54 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-09-26-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Sep 27 13:10:42 2018-date Thu Sep 27 13:05:54 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Thu Sep 27 13:10:42 2018-date Thu Sep 27 13:05:54 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PRef --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --eventcontent RAW --fileout file:RelVal_Raw_PRef_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Thu Sep 27 13:10:45 2018-date Thu Sep 27 13:05:59 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-09-26-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Sep 27 13:10:45 2018-date Thu Sep 27 13:05:59 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Thu Sep 27 13:10:45 2018-date Thu Sep 27 13:05:59 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full2015Data --data --scenario=HeavyIons -n 10 --conditions auto:run2_hlt_HIon --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --fileout file:RelVal_Raw_HIon_DATA.root --filein /store/hidata/HIRun2015/HIHardProbes/RAW-RECO/HighPtJet-PromptReco-v1/000/263/689/00000/1802CD9A-DDB8-E511-9CF9-02163E0138CA.root : FAILED - time: date Thu Sep 27 13:10:41 2018-date Thu Sep 27 13:06:02 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-09-26-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Sep 27 13:10:41 2018-date Thu Sep 27 13:06:02 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Thu Sep 27 13:10:41 2018-date Thu Sep 27 13:06:02 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PIon --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --eventcontent RAW --fileout file:RelVal_Raw_PIon_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Thu Sep 27 13:15:34 2018-date Thu Sep 27 13:10:41 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-09-26-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Sep 27 13:15:34 2018-date Thu Sep 27 13:10:41 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Thu Sep 27 13:15:34 2018-date Thu Sep 27 13:10:41 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_2018v35 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --fileout file:RelVal_Raw_2018v35_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Thu Sep 27 13:16:22 2018-date Thu Sep 27 13:10:51 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-09-26-2300/src/HLTrigger/Configuration/test/OnLine_HLT_2018v35.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Sep 27 13:16:22 2018-date Thu Sep 27 13:10:51 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:2018v35,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2018v35 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_2018v35_DATA.root --fileout file:RelVal_Raw_2018v35_DATA_HLT_RECO.root : FAILED - time: date Thu Sep 27 13:16:22 2018-date Thu Sep 27 13:10:51 2018 s - exit: 21504
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-09-26-2300/src/Utilities/ReleaseScripts/scripts/read312RV_cfg.py : FAILED - time: date Thu Sep 27 13:20:16 2018-date Thu Sep 27 13:16:22 2018 s - exit: 23552
cmsDriver.py RelVal -s L1REPACK:GT1 --data --scenario=pp -n 10 --conditions auto:run1_hlt_Fake --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_DATA.root --filein /store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root : FAILED - time: date Thu Sep 27 13:22:39 2018-date Thu Sep 27 13:16:27 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-09-26-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Sep 27 13:22:39 2018-date Thu Sep 27 13:16:27 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Thu Sep 27 13:22:39 2018-date Thu Sep 27 13:16:27 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_GRun --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --fileout file:RelVal_Raw_GRun_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Thu Sep 27 13:23:40 2018-date Thu Sep 27 13:17:41 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-09-26-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Sep 27 13:23:40 2018-date Thu Sep 27 13:17:41 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Thu Sep 27 13:23:40 2018-date Thu Sep 27 13:17:41 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:GCTGT --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake1 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_DATA.root --filein /store/data/Run2015D/MuonEG/RAW/v1/000/256/677/00000/80950A90-745D-E511-92FD-02163E011C5D.root : FAILED - time: date Thu Sep 27 13:23:27 2018-date Thu Sep 27 13:18:32 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-09-26-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Sep 27 13:23:27 2018-date Thu Sep 27 13:18:32 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_DATA.root --fileout file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Thu Sep 27 13:23:27 2018-date Thu Sep 27 13:18:32 2018 s - exit: 21504

cmsbuild · 2018-09-27T11:38:31Z

Comparison job queued.

perrotta · 2018-09-27T11:44:48Z

Failures in the HLT AddOn are unrelated

cmsbuild · 2018-09-27T13:15:45Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24680/30684/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3162160
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3161962
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 134 log files, 14 edm output root files, 32 DQM output files

cmsbuild · 2018-10-02T15:36:51Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-10-03T15:40:50Z

please test workflow 22434.0

cmsbuild · 2018-10-03T15:41:07Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30875/console Started: 2018/10/03 17:41

cmsbuild · 2018-10-03T17:53:36Z

+1
Tested at: 53c81cf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24680/30875/summary.html

cmsbuild · 2018-10-03T17:53:40Z

Comparison job queued.

cmsbuild · 2018-10-03T19:20:41Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24680/30875/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3162909
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3162710
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 134 log files, 14 edm output root files, 32 DQM output files

fabiocos · 2018-10-04T09:07:00Z

@smuzaffar the bot run the requested extra workflow 22434.0, not in the short matrix, produced the output, but did not report that comparisons cannot be done. Is this a new feature of the bot, or am I missing something?

fabiocos · 2018-10-04T09:07:17Z

+1

fix

smuzaffar · 2018-10-04T09:27:29Z

@fabiocos , comparison is only done for the short matrix workflows (as we only have results for those workflow for the ref IBs).

fabiocos · 2018-10-04T09:30:33Z

@smuzaffar indeed, and for other cases usually the bot reports it was not possible. But in this case it did not report anything, this is what puzzles me a bit...

smuzaffar · 2018-10-04T09:31:21Z

ah ok, let me check

smuzaffar · 2018-10-04T12:57:53Z

@fabiocos , the missing workflow comparison message (such as #24798 (comment) ) appears when we have workflows for which we are missing the entry in https://github.com/cms-sw/cms-bot/blob/master/comparisons/matrix_RE.txt file. For workflow 22434.0 the entry exists that is why we did see the warning.

fabiocos · 2018-10-04T14:57:36Z

@smuzaffar ok, I see, it is ready for insertion in the short matrix from the point of view of the bot, but it is not in the release...

perrotta added 2 commits September 27, 2018 10:52

rename MTD ModuleNumbering plugin in order to avoid duplicates

6bf9d4d

rename MTD ModuleNumbering plugin in order to avoid duplicates

53c81cf

cmsbuild added this to the CMSSW_10_3_X milestone Sep 27, 2018

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Sep 27, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 27, 2018

perrotta mentioned this pull request Sep 27, 2018

MTD Tracking Part 1 - Topology, Geometry, and Tracking Geometry #24285

Merged

cmsbuild added the bug-fix label Sep 27, 2018

cmsbuild added tests-started and removed tests-pending labels Sep 27, 2018

cmsbuild added tests-rejected and removed tests-started labels Sep 27, 2018

cmsbuild added comparison-available and removed comparison-pending labels Sep 27, 2018

cmsbuild added fully-signed upgrade-approved and removed upgrade-pending labels Oct 2, 2018

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Oct 3, 2018

cmsbuild added tests-started and removed tests-pending labels Oct 3, 2018

cmsbuild added tests-approved and removed tests-started labels Oct 3, 2018

cmsbuild added comparison-available and removed comparison-pending labels Oct 3, 2018

cmsbuild added orp-approved and removed orp-pending labels Oct 4, 2018

cmsbuild merged commit a1b82c4 into cms-sw:master Oct 4, 2018

perrotta deleted the renameMtdModuleNumberingPluginToAvoidDuplicates branch October 4, 2018 09:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename MTDModuleNumbering plugin to avoid duplicates #24680

Rename MTDModuleNumbering plugin to avoid duplicates #24680

perrotta commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

perrotta commented Sep 27, 2018

perrotta commented Sep 27, 2018

cmsbuild commented Sep 27, 2018 •

edited

cmsbuild commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

perrotta commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

cmsbuild commented Oct 2, 2018

fabiocos commented Oct 3, 2018

cmsbuild commented Oct 3, 2018 •

edited

cmsbuild commented Oct 3, 2018

cmsbuild commented Oct 3, 2018

cmsbuild commented Oct 3, 2018

fabiocos commented Oct 4, 2018

fabiocos commented Oct 4, 2018

smuzaffar commented Oct 4, 2018

fabiocos commented Oct 4, 2018

smuzaffar commented Oct 4, 2018

smuzaffar commented Oct 4, 2018

fabiocos commented Oct 4, 2018

Rename MTDModuleNumbering plugin to avoid duplicates #24680

Rename MTDModuleNumbering plugin to avoid duplicates #24680

Conversation

perrotta commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

perrotta commented Sep 27, 2018

perrotta commented Sep 27, 2018

cmsbuild commented Sep 27, 2018 • edited

cmsbuild commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

perrotta commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

cmsbuild commented Oct 2, 2018

fabiocos commented Oct 3, 2018

cmsbuild commented Oct 3, 2018 • edited

cmsbuild commented Oct 3, 2018

cmsbuild commented Oct 3, 2018

cmsbuild commented Oct 3, 2018

fabiocos commented Oct 4, 2018

fabiocos commented Oct 4, 2018

smuzaffar commented Oct 4, 2018

fabiocos commented Oct 4, 2018

smuzaffar commented Oct 4, 2018

smuzaffar commented Oct 4, 2018

fabiocos commented Oct 4, 2018

cmsbuild commented Sep 27, 2018 •

edited

cmsbuild commented Oct 3, 2018 •

edited