EventFilter/SiStripRawToDigi: replace auto_ptr removed in strict std=c++17

[gartung]

No description provided.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24707/6643

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

EventFilter/SiStripRawToDigi

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30707/console Started: 2018/09/27 20:50

[cmsbuild]

-1

Tested at: 468f3bc

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6cb583d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24707/30707/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24707/30707/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24707/30707/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-09-27-1100/src/DQM/SiStripMonitorHardware/src/SiStripSpyUnpacker.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-09-27-1100/src/DQM/SiStripMonitorHardware/src/SiStripFEDSpyBuffer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-09-27-1100/src/DQM/SiStripMonitorHardware/src/BuildTrackerMap.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-09-27-1100/src/DQM/SiStripMonitorHardware/src/SiStripSpyDigiConverter.cc 
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-09-27-1100/src/DQM/SiStripMonitorHardware/src/SiStripSpyUnpacker.cc: In member function 'void sistrip::SpyUnpacker::createDigis(const SiStripFedCabling&, const FEDRawDataCollection&, sistrip::SpyUnpacker::RawDigis*, const std::vector&, sistrip::SpyUnpacker::Counters*, sistrip::SpyUnpacker::Counters*, uint32_t*)':
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-09-27-1100/src/DQM/SiStripMonitorHardware/src/SiStripSpyUnpacker.cc:212:67: error: conversion from 'std::unique_ptr, std::default_delete > >' to non-scalar type 'std::auto_ptr >' requested
     std::auto_ptr pResult = dsvFiller.createDetSetVector();
                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-09-27-1100/src/DQM/SiStripMonitorHardware/src/SiStripSpyEventMatcher.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-09-27-1100/src/DQM/SiStripMonitorHardware/src/CMHistograms.cc 
gmake: *** [tmp/slc6_amd64_gcc700/src/DQM/SiStripMonitorHardware/src/DQMSiStripMonitorHardware/SiStripSpyUnpacker.cc.o] Error 1


The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6cb583d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24707/30707/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24707/30707/git-merge-result

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[gartung]

Merged coordinated change from
#24699

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24707/6694

[cmsbuild]

Pull request #24707 was updated. @perrotta, @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30747/console Started: 2018/09/28 05:57

[cmsbuild]

+1
Tested at: 4127956
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24707/30747/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4127956
323be9c
6cb583d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24707/30747/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24707/30747/git-merge-result

[cmsbuild]

Comparison job queued.

[andrius-k]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24707/30747/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3162160
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3161962
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[slava77]

+1

for #24707 4127956

• technical
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1