GeneratorInterface/Herwig7Interface: replace auto_ptr removed in strict std=c++17 #24715
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24715/6652 |
|
A new Pull Request was created by @gartung (Patrick Gartung) for master. It involves the following packages: GeneratorInterface/Herwig7Interface @alberto-sanchez, @cmsbuild, @qliphy, @perrozzi, @efeyazgan can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test workflow 511.0, 535.0 |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: b011b2e The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build ClangBuild
I found an error when building: >> Subsystem Utilities built
>> Entering Package GeneratorInterface/Herwig7Interface
Entering library rule at src/GeneratorInterface/Herwig7Interface/plugins
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-09-27-1100/src/GeneratorInterface/Herwig7Interface/plugins/Herwig7Hadronizer.cc
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-09-27-1100/src/GeneratorInterface/Herwig7Interface/plugins/Herwig7Hadronizer.cc: In member function 'bool Herwig7Hadronizer::generatePartonsAndHadronize()':
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-09-27-1100/src/GeneratorInterface/Herwig7Interface/plugins/Herwig7Hadronizer.cc:134:31: error: no match for 'operator=' (operand types are 'std::auto_ptr' and 'std::unique_ptr')
event() = convert(thepegEvent);
^
In file included from /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/external/gcc/7.0.0-omkpbe2/include/c++/7.3.1/memory:84:0,
from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-09-27-1100/src/GeneratorInterface/Herwig7Interface/plugins/Herwig7Hadronizer.cc:1:
/cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/external/gcc/7.0.0-omkpbe2/include/c++/7.3.1/backward/auto_ptr.h:136:7: note: candidate: std::auto_ptr< >& std::auto_ptr< >::operator=(std::auto_ptr< >&) [with _Tp = HepMC::GenEvent]
I found a compilation error while trying to compile with clang: >> Local Products Rules ..... done >> Creating project symlinks >> Entering Package GeneratorInterface/Herwig7Interface >> Entering Package DQM/HcalTasks >> Compile sequence completed for CMSSW CMSSW_10_3_X_2018-09-27-1100 gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
…cxx17' into GeneratorInterface-Herwig7Interface-strictcxx17
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
tests-started
labels
|
The code-checks are being triggered in jenkins. |
|
Required coordinated change to GeneratorInterface/Core |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24715/6693 |
|
Pull request #24715 was updated. @alberto-sanchez, @cmsbuild, @qliphy, @perrozzi, @efeyazgan can you please check and sign again. |
|
please test workflow 511.0, 535.0 |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
No description provided.