PhysicsTools/CondLiteIO: replace auto_ptr removed in strict implementation of std=c++17 #24750

gartung · 2018-09-27T20:47:45Z

No description provided.

…ation of std=c++17

cmsbuild · 2018-09-27T20:48:02Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-09-27T20:50:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24750/6691

cmsbuild · 2018-09-27T20:50:33Z

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

PhysicsTools/CondLiteIO

@gpetruc, @cmsbuild, @arizzi, @monttj can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

gartung · 2018-09-28T15:47:30Z

@Dr15Jones please test

Dr15Jones · 2018-09-28T17:23:03Z

please test

cmsbuild · 2018-09-28T17:23:21Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30776/console Started: 2018/09/28 20:06

cmsbuild · 2018-09-28T19:31:39Z

-1

Tested at: 9185141

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24750/30776/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.731 step2

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step2_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

1325.7 step2

runTheMatrix-results/1325.7_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2/step2_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2.log

136.788 step2

runTheMatrix-results/136.788_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017/step2_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake2 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --fileout file:RelVal_Raw_Fake2_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Fri Sep 28 21:11:46 2018-date Fri Sep 28 21:11:01 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 21:11:46 2018-date Fri Sep 28 21:11:01 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 21:11:46 2018-date Fri Sep 28 21:11:01 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PRef --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --eventcontent RAW --fileout file:RelVal_Raw_PRef_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Fri Sep 28 21:12:05 2018-date Fri Sep 28 21:11:05 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 21:12:05 2018-date Fri Sep 28 21:11:05 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 21:12:05 2018-date Fri Sep 28 21:11:05 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full2015Data --data --scenario=HeavyIons -n 10 --conditions auto:run2_hlt_HIon --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --fileout file:RelVal_Raw_HIon_DATA.root --filein /store/hidata/HIRun2015/HIHardProbes/RAW-RECO/HighPtJet-PromptReco-v1/000/263/689/00000/1802CD9A-DDB8-E511-9CF9-02163E0138CA.root : FAILED - time: date Fri Sep 28 21:11:55 2018-date Fri Sep 28 21:11:09 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 21:11:55 2018-date Fri Sep 28 21:11:09 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 21:11:55 2018-date Fri Sep 28 21:11:09 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PIon --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --eventcontent RAW --fileout file:RelVal_Raw_PIon_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Fri Sep 28 21:12:18 2018-date Fri Sep 28 21:11:23 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 21:12:18 2018-date Fri Sep 28 21:11:23 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 21:12:18 2018-date Fri Sep 28 21:11:23 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_2018v35 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --fileout file:RelVal_Raw_2018v35_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Fri Sep 28 21:14:06 2018-date Fri Sep 28 21:11:27 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_2018v35.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 21:14:06 2018-date Fri Sep 28 21:11:27 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:2018v35,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2018v35 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_2018v35_DATA.root --fileout file:RelVal_Raw_2018v35_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 21:14:06 2018-date Fri Sep 28 21:11:27 2018 s - exit: 21504
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/Utilities/ReleaseScripts/scripts/read312RV_cfg.py : FAILED - time: date Fri Sep 28 21:11:42 2018-date Fri Sep 28 21:11:37 2018 s - exit: 23552
cmsDriver.py RelVal -s L1REPACK:GT1 --data --scenario=pp -n 10 --conditions auto:run1_hlt_Fake --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_DATA.root --filein /store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root : FAILED - time: date Fri Sep 28 21:12:29 2018-date Fri Sep 28 21:11:39 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 21:12:29 2018-date Fri Sep 28 21:11:39 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 21:12:29 2018-date Fri Sep 28 21:11:39 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_GRun --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --fileout file:RelVal_Raw_GRun_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Fri Sep 28 21:14:41 2018-date Fri Sep 28 21:11:41 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 21:14:41 2018-date Fri Sep 28 21:11:41 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 21:14:41 2018-date Fri Sep 28 21:11:41 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:GCTGT --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake1 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_DATA.root --filein /store/data/Run2015D/MuonEG/RAW/v1/000/256/677/00000/80950A90-745D-E511-92FD-02163E011C5D.root : FAILED - time: date Fri Sep 28 21:12:38 2018-date Fri Sep 28 21:11:45 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 21:12:38 2018-date Fri Sep 28 21:11:45 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_DATA.root --fileout file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 21:12:38 2018-date Fri Sep 28 21:11:45 2018 s - exit: 21504

cmsbuild · 2018-09-28T19:31:41Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

gartung · 2018-09-28T19:35:57Z

Failed to read file from eos because of expired/missing authentication.
@Dr15Jones please test again

fabiocos · 2018-10-01T12:15:29Z

please test

cmsbuild · 2018-10-01T12:15:47Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30818/console Started: 2018/10/01 14:17

cmsbuild · 2018-10-01T14:18:43Z

+1
Tested at: 9185141
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24750/30818/summary.html

cmsbuild · 2018-10-01T14:18:45Z

Comparison job queued.

cmsbuild · 2018-10-01T15:38:44Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24750/30818/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3162800
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3162601
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 134 log files, 14 edm output root files, 32 DQM output files

fabiocos · 2018-10-02T08:38:50Z

+1

fabiocos · 2018-10-02T08:38:55Z

merge

PhysicsTools/CondLiteIO: replace auto_ptr removed in strict implement…

9185141

…ation of std=c++17

cmsbuild added this to the CMSSW_10_3_X milestone Sep 27, 2018

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures tests-pending labels Sep 27, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 27, 2018

cmsbuild added tests-started and removed tests-pending labels Sep 28, 2018

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Sep 28, 2018

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Oct 1, 2018

cmsbuild added tests-started and removed tests-pending labels Oct 1, 2018

cmsbuild added tests-approved and removed tests-started labels Oct 1, 2018

cmsbuild added comparison-available and removed comparison-pending labels Oct 1, 2018

cmsbuild added orp-approved and removed orp-pending labels Oct 2, 2018

cmsbuild merged commit e4d0460 into cms-sw:master Oct 2, 2018

gartung deleted the PhysicsTools-CondLiteIO-strictcxx17 branch November 5, 2018 15:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PhysicsTools/CondLiteIO: replace auto_ptr removed in strict implementation of std=c++17 #24750

PhysicsTools/CondLiteIO: replace auto_ptr removed in strict implementation of std=c++17 #24750

gartung commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

gartung commented Sep 28, 2018

Dr15Jones commented Sep 28, 2018

cmsbuild commented Sep 28, 2018 •

edited

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

gartung commented Sep 28, 2018

fabiocos commented Oct 1, 2018

cmsbuild commented Oct 1, 2018 •

edited

cmsbuild commented Oct 1, 2018

cmsbuild commented Oct 1, 2018

cmsbuild commented Oct 1, 2018

fabiocos commented Oct 2, 2018

fabiocos commented Oct 2, 2018

PhysicsTools/CondLiteIO: replace auto_ptr removed in strict implementation of std=c++17 #24750

PhysicsTools/CondLiteIO: replace auto_ptr removed in strict implementation of std=c++17 #24750

Conversation

gartung commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

cmsbuild commented Sep 27, 2018

gartung commented Sep 28, 2018

Dr15Jones commented Sep 28, 2018

cmsbuild commented Sep 28, 2018 • edited

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

gartung commented Sep 28, 2018

fabiocos commented Oct 1, 2018

cmsbuild commented Oct 1, 2018 • edited

cmsbuild commented Oct 1, 2018

cmsbuild commented Oct 1, 2018

cmsbuild commented Oct 1, 2018

fabiocos commented Oct 2, 2018

fabiocos commented Oct 2, 2018

cmsbuild commented Sep 28, 2018 •

edited

cmsbuild commented Oct 1, 2018 •

edited