some quick damage control to uninitialized arrays and global statics in CastorDigiMonitor

[slava77]

I came across this when checking for random differences that recently appeared in CASTOR monitoring plots.

There should be a proper fix to the non-const statics. I have only made them local with a quick fix.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24760/6702

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

DQM/CastorMonitor

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30792/console Started: 2018/09/28 22:31

[cmsbuild]

+1
Tested at: a322137
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24760/30792/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
047249b
688da1d
3b5964f
188fe63
43cc536
5718c62
46cfc89
90d3b5a
9540ef0
bb77653
8f7cc5b
fa3f8d6
acc1167
80f3405
31d6122
5085974
b74fb16
0aeffb8
d3126ee
c1d49aa
413d1c3
e9db315
dc1a3a5
fdcf96e
e857f0a
d133c94
b1ad01c
a4808ce
d656880
a02e95f
0f4e69e
76f5d38
54dd68c
1f9c419
b2d409f
5644ba5
5561894
c43444e
286baaa
91326c6
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24760/30792/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24760/30792/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24760/30792/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 901 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3161989
• DQMHistoTests: Total failures: 5327
• DQMHistoTests: Total nulls: 12
• DQMHistoTests: Total successes: 3156453
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 189.586 KiB( 31 files compared)
• DQMHistoSizes: changed ( 10824.0,... ): 78.688 KiB HLT/TAU
• DQMHistoSizes: changed ( 10824.0,... ): 0.159 KiB HLT/GeneralHLTOffline
• DQMHistoSizes: changed ( 136.85 ): 31.732 KiB HLT/TAU
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[andrius-k]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30842/console Started: 2018/10/02 10:43

[cmsbuild]

+1
Tested at: a322137
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24760/30842/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24760/30842/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3162800
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3162600
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

+1

fix