Bug fixes for new PluginDescription code #24797
Conversation
One will cause an exception in the case where there is a default type and the type is specified. The second causes edmPluginHelp to print multiple descriptions for the plugin. The third only affects the test module.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24797/6741 |
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: FWCore/Integration @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
bugfix |
|
type bugfix |
|
+1 |
cmsbuild
added
bug-fix
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
One will cause an exception in the case where there is
a default type and the type is specified. The second
causes edmPluginHelp to print multiple descriptions for
the plugin. The third only affects the test module.
Note it is unlikely this will cause problems in the release as
the only thing currently using the PluginDescription code is
Framework unit tests, but it would be nice to get this merged
quickly as we are encouraging developers to try PluginDescription
and these fixes will help the first users avoid problems.