-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert back from oversight about rawDataRepacker and rawDataCollector for the BeamPixel DQM application #24803
Revert back from oversight about rawDataRepacker and rawDataCollector for the BeamPixel DQM application #24803
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24803/6749 |
A new Pull Request was created by @dinardo (Mauro) for master. It involves the following packages: DQM/Integration @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The code-checks are being triggered in jenkins. |
This is a backport from PR #24802 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24803/6750 |
Pull request #24803 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please check and sign again. |
please test |
Hi @dinardo, could you please make sure that there is a name of the subsystem in the title of the PR? |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Hi @dinardo, could you please make sure that there is a name of the subsystem in the title of the PR? |
Hi Anrdius,
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@dinardo Thanks! |
@dinardo this PR needs a 10_3_X backport I would say |
+1 |
In making a change to the code I, wrongly, realized that I could merge two sections of the code.
I was wrong because I confused
rawDataCollector
withrawDataRepacker
.I reverted back to the original form.
Sorry about that.