Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert back from oversight about rawDataRepacker and rawDataCollector for the BeamPixel DQM application #24803

Merged
merged 2 commits into from
Oct 15, 2018
Merged

Revert back from oversight about rawDataRepacker and rawDataCollector for the BeamPixel DQM application #24803

merged 2 commits into from
Oct 15, 2018

Conversation

dinardo
Copy link
Contributor

@dinardo dinardo commented Oct 4, 2018

In making a change to the code I, wrongly, realized that I could merge two sections of the code.
I was wrong because I confused rawDataCollector with rawDataRepacker.
I reverted back to the original form.
Sorry about that.

  • Mauro.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

A new Pull Request was created by @dinardo (Mauro) for master.

It involves the following packages:

DQM/Integration

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@makortel, @threus, @batinkov, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

The code-checks are being triggered in jenkins.

@dinardo
Copy link
Contributor Author

dinardo commented Oct 4, 2018

This is a backport from PR #24802

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

Pull request #24803 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please check and sign again.

@andrius-k
Copy link

please test

@andrius-k
Copy link

Hi @dinardo, could you please make sure that there is a name of the subsystem in the title of the PR?

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30891/console Started: 2018/10/04 18:18

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24803/30891/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3162909
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3162711
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 8426.92 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 150.0,... ): 3370.768 KiB JetMET/HIJetValidation
  • DQMHistoSizes: changed ( 158.0 ): 1685.384 KiB JetMET/HIJetValidation
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@andrius-k
Copy link

Hi @dinardo, could you please make sure that there is a name of the subsystem in the title of the PR?

@dinardo dinardo changed the title Revert back from oversight about rawDataRepacker and rawDataCollector Revert back from oversight about rawDataRepacker and rawDataCollector for the BeamPixel DQM application Oct 15, 2018
@dinardo
Copy link
Contributor Author

dinardo commented Oct 15, 2018

Hi Anrdius,
ok it's done.

  • Mauro.

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@andrius-k
Copy link

@dinardo Thanks!

@fabiocos
Copy link
Contributor

@dinardo this PR needs a 10_3_X backport I would say

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9ef8b40 into cms-sw:master Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants