Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mixing scenario for PU250 PU300 in Configuration/StandardSequences/python/Mixing.py #24808

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

siddhesh86
Copy link
Contributor

Added mixing scenaring AVE_250_BX_25ns and AVE_300_BX_25ns for PU250, PU300 in Configuration/StandardSequences/python/Mixing.py with CMSSW_9_3_7.

… PU300 in Configuration/StandardSequences/python/Mixing.py
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

A new Pull Request was created by @siddhesh86 for CMSSW_9_3_X.

It involves the following packages:

Configuration/StandardSequences

@cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos, @kpedro88 you are the release manager for this.

cms-bot commands are listed here

@siddhesh86 siddhesh86 changed the title Added mixing scenaring PU250 PU300 in Configuration/StandardSequences/python/Mixing.py Added mixing scenaring for PU250 PU300 in Configuration/StandardSequences/python/Mixing.py Oct 4, 2018
@siddhesh86 siddhesh86 changed the title Added mixing scenaring for PU250 PU300 in Configuration/StandardSequences/python/Mixing.py Added mixing scenario for PU250 PU300 in Configuration/StandardSequences/python/Mixing.py Oct 4, 2018
@kpedro88
Copy link
Contributor

kpedro88 commented Oct 4, 2018

please test

@kpedro88
Copy link
Contributor

kpedro88 commented Oct 4, 2018

@siddhesh86 is this a backport?

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30893/console Started: 2018/10/04 23:11

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2018

Comparison job queued.

@siddhesh86
Copy link
Contributor Author

@siddhesh86 is this a backport?

Actually, I want these modifications to generate few samples (with CMSSW_9_3_7) urgently needed for high PU test with tracker reconstruction. It would be good to have high PU scenarios in latest releases also. But for this pull request, today I started with the latest repository on CMSSW9_3_X branch and added those two lines.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24808/30893/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2624448
  • DQMHistoTests: Total failures: 218
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2624053
  • DQMHistoTests: Total skipped: 177
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -24 KiB( 24 files compared)
  • Checked 105 log files, 8 edm output root files, 25 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Oct 5, 2018

Please submit a corresponding PR to the master branch

@siddhesh86
Copy link
Contributor Author

Please submit a corresponding PR to the master branch
I have submitted a corresponding pull request to the master branch (PR #24821). Thank you Kevin.

@kpedro88
Copy link
Contributor

kpedro88 commented Oct 8, 2018

backport of #24821

@kpedro88
Copy link
Contributor

kpedro88 commented Oct 9, 2018

@siddhesh86 we would like to understand the use case for this PR in 93X. The state of the phase 2 tracker (geometry, digitization, etc.) has developed substantially since 93X was used for last year's TDRs. Is there a concrete plan for what samples will be produced with 300PU, what timescale is necessary, and what we expect to learn? Otherwise it might be easier and more profitable to use 10_3_X or 10_4_X along with the upcoming MTD TDR production.

@cmsbuild cmsbuild removed the backport label Oct 9, 2018
@siddhesh86
Copy link
Contributor Author

@kpedro88 SingleNeutrino samples were produced with PU0, 140 and 200 with CMSSW_9_3_7. Now its PU250 and 300 samples are needed for TrackTrigger stress tests and they are needed to be produced with the same cmssw release.

@boudoul
Copy link
Contributor

boudoul commented Oct 9, 2018

Hello @siddhesh86 I'm sorry but I'm connfused :

The results of the stress test , in particular performance with samples at PU 250-300 have been presented last week at Budapest during the CMS week, see for example slide 7-8-9 https://indico.cern.ch/event/704625/contributions/3148729/attachments/1728209/2792182/StressTest_CMSweek_4oct2018.pdf
The samples are liste on slide 21.

After this presentation, the stress test has been declared over by the stress test committee : https://indico.cern.ch/event/704625/contributions/3148730/attachments/1728364/2792516/closeout.pdf
...

@siddhesh86
Copy link
Contributor Author

Hello @boudoul , I produced ttbar RelVal samples with PU250, 300 by manually implementing the modifications (that I proposed in this pull request) into my local cmssw. Now I have to produce SingleNeutrino samples with higher PU using McM tool. The McM fetches cmssw on its own. So I need these high PU scenarios in the official cmssw release.

@boudoul
Copy link
Contributor

boudoul commented Oct 9, 2018

thanks @siddhesh86 . I know the technicalities of MCM, but the point is more to understand the use case since you wrote that it is for the stress test but the stress test has been declared over last week. This is why I'm confused about the use case...

@siddhesh86
Copy link
Contributor Author

@boudoul: I got the request for SingleNeutrino sample saying it is needed for the stress test. Sorry but I don't know about it in much detail.

@rekovic
Copy link
Contributor

rekovic commented Oct 10, 2018

Hi @boudul
Stress tests you are mentioning were done for the Track Trigger using TTBar RelVal samples.
For the Phase2 Level-1 Trigger, PU250 and PU300 NuGun and a few signal samples are needed for the stress tests of the algorithms under development (to evaluate rates and efficiencies in severe conditions and identify points of failure).

@rekovic
Copy link
Contributor

rekovic commented Oct 10, 2018

Hi @boudoul
Stress tests you are mentioning were done for the Track Trigger using TTBar RelVal samples.
For the Phase2 Level-1 Trigger, PU250 and PU300 NuGun and a few signal samples are needed for the stress tests of the algorithms under development (to evaluate rates and efficiencies in severe conditions and identify points of failure).

@siddhesh86
Copy link
Contributor Author

Hi all,
Have you reached any conclusion/decision about this pull request?

@rekovic
Copy link
Contributor

rekovic commented Oct 12, 2018

@fabiocos
I don't see any issue with this simple PR and should be merged so we can produce samples.

@fabiocos
Copy link
Contributor

@rekovic @boudoul @kpedro88 @siddhesh86 the PR itself is trivial, and I caan merge it. The general plan for studies is outside the scope of this discussion, and should be better clarified. In general I would push to move the work to a newer code base

@fabiocos
Copy link
Contributor

+operations

trivial addition of new mixing scenarios

@fabiocos
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 1481711 into cms-sw:CMSSW_9_3_X Oct 12, 2018
@siddhesh86
Copy link
Contributor Author

Thank you for merging the modifications into cmssw_9_3_X branch.
Can you please tell me in which cmssw release these modifications will be included? And do I have to do something for that?

@kpedro88
Copy link
Contributor

a release is being built, see: #24864

@siddhesh86
Copy link
Contributor Author

Thank you @kpedro88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants