HI Plots for the CaloLayer2 DQM #24835

vukasinmilosevic · 2018-10-09T12:19:35Z

Centrality and Asymmetry plots as well as the event-by-event comparison requested in:
https://its.cern.ch/jira/browse/CMSLITDPG-693

cmsbuild · 2018-10-09T12:19:48Z

@vukasinmilosevic, CMSSW_10_3_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

cmsbuild · 2018-10-09T12:20:09Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-10-09T12:22:51Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24835/6784

cmsbuild · 2018-10-09T12:23:11Z

A new Pull Request was created by @vukasinmilosevic (Vukasin Milosevic) for master.

It involves the following packages:

DQM/L1TMonitor
DQM/L1TMonitorClient

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

thomreis · 2018-10-09T12:29:07Z

please test

cmsbuild · 2018-10-09T12:29:21Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30938/console Started: 2018/10/09 14:29

thomreis · 2018-10-09T12:59:26Z

Hi @vukasinmilosevic
for the online DQM please also provide a PR to the 10_2_X branch.

vukasinmilosevic · 2018-10-09T14:04:25Z

Hi @thomreis,
The HI variables are not in the 10_2_X branch. I was told to provide a 10_3_X for online DQM.

thomreis · 2018-10-09T14:19:08Z

I see. OK in that case this should be fine. Thanks.

cmsbuild · 2018-10-09T15:07:26Z

-1

Tested at: d586ad8

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24835/30938/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake2 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --fileout file:RelVal_Raw_Fake2_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Tue Oct 9 16:39:17 2018-date Tue Oct 9 16:34:23 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02545/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-10-09-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Oct 9 16:39:17 2018-date Tue Oct 9 16:34:23 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Tue Oct 9 16:39:17 2018-date Tue Oct 9 16:34:23 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PRef --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --eventcontent RAW --fileout file:RelVal_Raw_PRef_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Tue Oct 9 16:39:21 2018-date Tue Oct 9 16:34:25 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02545/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-10-09-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Oct 9 16:39:21 2018-date Tue Oct 9 16:34:25 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Tue Oct 9 16:39:21 2018-date Tue Oct 9 16:34:25 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full2015Data --data --scenario=HeavyIons -n 10 --conditions auto:run2_hlt_HIon --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --fileout file:RelVal_Raw_HIon_DATA.root --filein /store/hidata/HIRun2015/HIHardProbes/RAW-RECO/HighPtJet-PromptReco-v1/000/263/689/00000/1802CD9A-DDB8-E511-9CF9-02163E0138CA.root : FAILED - time: date Tue Oct 9 16:40:11 2018-date Tue Oct 9 16:34:27 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02545/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-10-09-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Oct 9 16:40:11 2018-date Tue Oct 9 16:34:27 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Tue Oct 9 16:40:11 2018-date Tue Oct 9 16:34:27 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_2018v36 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --fileout file:RelVal_Raw_2018v36_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Tue Oct 9 16:45:08 2018-date Tue Oct 9 16:38:47 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02545/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-10-09-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2018v36.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Oct 9 16:45:08 2018-date Tue Oct 9 16:38:47 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:2018v36,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2018v36 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_2018v36_DATA.root --fileout file:RelVal_Raw_2018v36_DATA_HLT_RECO.root : FAILED - time: date Tue Oct 9 16:45:08 2018-date Tue Oct 9 16:38:47 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PIon --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --eventcontent RAW --fileout file:RelVal_Raw_PIon_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Tue Oct 9 16:44:14 2018-date Tue Oct 9 16:39:21 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02545/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-10-09-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Oct 9 16:44:14 2018-date Tue Oct 9 16:39:21 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Tue Oct 9 16:44:14 2018-date Tue Oct 9 16:39:21 2018 s - exit: 21504
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02545/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-10-09-1100/src/Utilities/ReleaseScripts/scripts/read312RV_cfg.py : FAILED - time: date Tue Oct 9 16:48:05 2018-date Tue Oct 9 16:44:20 2018 s - exit: 23552
cmsDriver.py RelVal -s L1REPACK:GT1 --data --scenario=pp -n 10 --conditions auto:run1_hlt_Fake --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_DATA.root --filein /store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root : FAILED - time: date Tue Oct 9 16:48:24 2018-date Tue Oct 9 16:45:11 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02545/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-10-09-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Oct 9 16:48:24 2018-date Tue Oct 9 16:45:11 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Tue Oct 9 16:48:24 2018-date Tue Oct 9 16:45:11 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_GRun --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --fileout file:RelVal_Raw_GRun_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Tue Oct 9 16:51:04 2018-date Tue Oct 9 16:46:25 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02545/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-10-09-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Oct 9 16:51:04 2018-date Tue Oct 9 16:46:25 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Tue Oct 9 16:51:04 2018-date Tue Oct 9 16:46:25 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:GCTGT --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake1 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_DATA.root --filein /store/data/Run2015D/MuonEG/RAW/v1/000/256/677/00000/80950A90-745D-E511-92FD-02163E011C5D.root : FAILED - time: date Tue Oct 9 16:52:14 2018-date Tue Oct 9 16:47:28 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02545/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-10-09-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Oct 9 16:52:14 2018-date Tue Oct 9 16:47:28 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_DATA.root --fileout file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Tue Oct 9 16:52:14 2018-date Tue Oct 9 16:47:28 2018 s - exit: 21504

cmsbuild · 2018-10-09T15:07:28Z

Comparison job queued.

cmsbuild · 2018-10-09T16:49:09Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30948/console Started: 2018/10/09 18:50

cmsbuild · 2018-10-09T19:37:05Z

+1
Tested at: d586ad8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24835/30948/summary.html

cmsbuild · 2018-10-09T19:37:09Z

Comparison job queued.

cmsbuild · 2018-10-09T21:37:32Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24835/30948/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3162979
DQMHistoTests: Total failures: 17
DQMHistoTests: Total nulls: 13
DQMHistoTests: Total successes: 3162752
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 72.149 KiB( 31 files compared)
DQMHistoSizes: changed ( 25202.0,... ): 3.671 KiB L1TEMU/L1TStage2CaloLayer2
DQMHistoSizes: changed ( 25202.0,... ): 1.140 KiB L1T/L1TStage2CaloLayer2
DQMHistoSizes: changed ( 150.0,... ): 3.663 KiB L1TEMU/L1TStage2CaloLayer2
Checked 134 log files, 14 edm output root files, 32 DQM output files

fabiocos · 2018-10-10T07:56:37Z

DQM/L1TMonitor/src/L1TStage2CaloLayer2.cc

@@ -293,9 +296,17 @@ void L1TStage2CaloLayer2::analyze(const edm::Event & e, const edm::EventSetup &
 	  stage2CaloLayer2ETTEMRank_->Fill(itEtSum->hwPt());
 	} else if (l1t::EtSum::EtSumType::kTowerCount == itEtSum->getType()) {
 	  stage2CaloLayer2TowCount_->Fill(itEtSum->hwPt());
-	} else{
+	} else if (l1t::EtSum::EtSumType::kTotalHt == itEtSum->getType()){


@vukasinmilosevic the differences observed in the DQM plots for non HI workflows come from here I guess, am I correct? Is this desired?

Hi, that is the only difference in filling the plots (besides the additional plots). I was told to use that EtSumType (kTotalHT) connected to HTTRank

fabiocos · 2018-10-12T08:16:31Z

@jfernan2 @andrius-k is this PR ok for you?

andrius-k · 2018-10-15T10:49:06Z

+1

cmsbuild · 2018-10-15T10:49:26Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-10-15T11:15:38Z

+1

thomreis · 2018-10-15T11:22:45Z

Hi @vukasinmilosevic
if this needs to go in 10_3 then you need to make a backport since master now points to 10_4 already.

vukasinmilosevic added 6 commits October 9, 2018 14:11

Adding Centrality and Asymmetry plots

deb832e

Typo fix and binning change for the centrality plot

ecb8b38

Bin fix

6e8cd27

Adding the option if centr = 0

f19d769

Adding the Event by Event comparison

77694fa

Adding styling changes

d586ad8

cmsbuild changed the base branch from CMSSW_10_3_X to master October 9, 2018 12:19

cmsbuild added this to the CMSSW_10_3_X milestone Oct 9, 2018

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Oct 9, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 9, 2018

cmsbuild added tests-started and removed tests-pending labels Oct 9, 2018

cmsbuild removed the tests-started label Oct 9, 2018

cmsbuild added comparison-pending tests-pending labels Oct 9, 2018

cmsbuild added tests-started and removed tests-pending labels Oct 9, 2018

cmsbuild added tests-approved and removed tests-started labels Oct 9, 2018

cmsbuild added comparison-available and removed comparison-pending labels Oct 9, 2018

fabiocos reviewed Oct 10, 2018

View reviewed changes

smuzaffar modified the milestones: CMSSW_10_3_X, CMSSW_10_4_X Oct 10, 2018

thomreis mentioned this pull request Oct 10, 2018

HI additional plots cms-l1t-offline/cmssw#727

Closed

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Oct 15, 2018

cmsbuild added orp-approved and removed orp-pending labels Oct 15, 2018

cmsbuild merged commit 57a1f0f into cms-sw:master Oct 15, 2018

vukasinmilosevic mentioned this pull request Oct 15, 2018

HI Plots for the CaloLayer2 DQM #24868

Merged

fabiocos mentioned this pull request Oct 15, 2018

Features to finalize CMSSW_10_3_0 #24869

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HI Plots for the CaloLayer2 DQM #24835

HI Plots for the CaloLayer2 DQM #24835

vukasinmilosevic commented Oct 9, 2018

cmsbuild commented Oct 9, 2018

cmsbuild commented Oct 9, 2018

cmsbuild commented Oct 9, 2018

cmsbuild commented Oct 9, 2018

thomreis commented Oct 9, 2018

cmsbuild commented Oct 9, 2018 •

edited

thomreis commented Oct 9, 2018

vukasinmilosevic commented Oct 9, 2018

thomreis commented Oct 9, 2018

cmsbuild commented Oct 9, 2018

cmsbuild commented Oct 9, 2018

cmsbuild commented Oct 9, 2018 •

edited

cmsbuild commented Oct 9, 2018

cmsbuild commented Oct 9, 2018

cmsbuild commented Oct 9, 2018

fabiocos Oct 10, 2018

vukasinmilosevic Oct 10, 2018 •

edited

fabiocos commented Oct 12, 2018

andrius-k commented Oct 15, 2018

cmsbuild commented Oct 15, 2018

fabiocos commented Oct 15, 2018

thomreis commented Oct 15, 2018

HI Plots for the CaloLayer2 DQM #24835

HI Plots for the CaloLayer2 DQM #24835

Conversation

vukasinmilosevic commented Oct 9, 2018

cmsbuild commented Oct 9, 2018

cmsbuild commented Oct 9, 2018

cmsbuild commented Oct 9, 2018

cmsbuild commented Oct 9, 2018

thomreis commented Oct 9, 2018

cmsbuild commented Oct 9, 2018 • edited

thomreis commented Oct 9, 2018

vukasinmilosevic commented Oct 9, 2018

thomreis commented Oct 9, 2018

cmsbuild commented Oct 9, 2018

cmsbuild commented Oct 9, 2018

cmsbuild commented Oct 9, 2018 • edited

cmsbuild commented Oct 9, 2018

cmsbuild commented Oct 9, 2018

cmsbuild commented Oct 9, 2018

fabiocos Oct 10, 2018

Choose a reason for hiding this comment

vukasinmilosevic Oct 10, 2018 • edited

Choose a reason for hiding this comment

fabiocos commented Oct 12, 2018

andrius-k commented Oct 15, 2018

cmsbuild commented Oct 15, 2018

fabiocos commented Oct 15, 2018

thomreis commented Oct 15, 2018

cmsbuild commented Oct 9, 2018 •

edited

cmsbuild commented Oct 9, 2018 •

edited

vukasinmilosevic Oct 10, 2018 •

edited