Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DQMOffline/Validation] BTV Updates #24842

Merged

Conversation

swertz
Copy link
Contributor

@swertz swertz commented Oct 10, 2018

  • Small bugfix: for some reason the JEC was applied twice. The only effect of the JEC on the BTV validation is through the Pt cut applied when filling the histograms.

  • Update the Loose working point for taggers where we monitor the efficiency vs. eta and phi

  • For deepCSV we now validate the B, CvsL and CvsB discriminators instead of the individual probabilities

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @swertz (Sébastien Wertz) for master.

It involves the following packages:

DQMOffline/RecoB
Validation/RecoB

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@imarches, @smoortga, @acaudron, @HeinerTholen, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@smuzaffar smuzaffar modified the milestones: CMSSW_10_3_X, CMSSW_10_4_X Oct 10, 2018
@andrius-k
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 10, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30960/console Started: 2018/10/10 14:01

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24842/30960/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3157597
  • DQMHistoTests: Total failures: 6562
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3150838
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -580.683 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 11624.0,... ): 27.709 KiB Btag/deepCSV_BvsAll_GLOBAL
  • DQMHistoSizes: changed ( 11624.0,... ): 27.436 KiB Btag/deepCSV_CvsB_GLOBAL
  • DQMHistoSizes: changed ( 11624.0,... ): 27.436 KiB Btag/deepCSV_CvsL_GLOBAL
  • DQMHistoSizes: changed ( 11624.0,... ): -27.055 KiB Btag/deepCSV_probudsg_GLOBAL
  • DQMHistoSizes: changed ( 11624.0,... ): -26.828 KiB Btag/deepCSV_probbb_GLOBAL
  • DQMHistoSizes: changed ( 11624.0,... ): -26.715 KiB Btag/deepCSV_probb_GLOBAL
  • DQMHistoSizes: changed ( 11624.0,... ): -26.715 KiB Btag/deepCSV_probc_GLOBAL
  • DQMHistoSizes: changed ( 11624.0,... ): 4.530 KiB Btag/deepCSV_BvsAll_ETA_1v4-2v4
  • DQMHistoSizes: changed ( 11624.0,... ): 4.491 KiB Btag/deepCSV_BvsAll_ETA_0-1v4
  • DQMHistoSizes: changed ( 11624.0,... ): 4.491 KiB Btag/deepCSV_CvsB_ETA_1v4-2v4
  • DQMHistoSizes: changed ( 11624.0 ): ...
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

the changes are concentrated in the btag sector, as expected from the PR changes

@cmsbuild cmsbuild merged commit 021dc59 into cms-sw:master Oct 12, 2018
@swertz swertz deleted the btvValUpdates-PR_from-CMSSW_10_3_0_pre4 branch October 26, 2018 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants