Extend EventSetup produce method return types

[wddgit]

Allow the produce functions of EventSetup ESProducers to
return unique_ptr < const T > and shared_ptr < const T >
without having to register const T in addition to registering T.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24844/6802

[cmsbuild]

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

FWCore/Framework
FWCore/Integration

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[wddgit]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30967/console Started: 2018/10/10 22:58

[cmsbuild]

+1
Tested at: d8b1ecf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24844/30967/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24844/30967/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2433 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3162979
• DQMHistoTests: Total failures: 9915
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3152867
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.117 KiB( 31 files compared)
• DQMHistoSizes: changed ( 250202.181 ): -0.117 KiB SiStrip/MechanicalView
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[Dr15Jones]

please test
given the large number of reported differences with base line, best to see if they were caused by other pull requests.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30985/console Started: 2018/10/11 18:11

[cmsbuild]

Pull request #24844 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31046/console Started: 2018/10/15 20:48

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Tested at: d1b8467

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24844/31046/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

(updated by muzaffar: this is failing due to root update)

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24844/31046/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2994723
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2994525
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[smuzaffar]

unit test is failing IB too due to root update.

[fabiocos]

+1