Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OfflineDQM: Offline L1T muon DQM bugfix for muon resolution plots CMSLITDPG-763 #24870

Merged
merged 1 commit into from Oct 16, 2018

Conversation

stahlleiton
Copy link
Contributor

Bugfix
This PR disables the extrapolation of L1T muons in the offline L1T DQM, since offline muons are extrapolated now to the muon stations. Requested in https://its.cern.ch/jira/browse/CMSLITDPG-763

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @stahlleiton (Andre Stahl) for master.

It involves the following packages:

DQMOffline/L1Trigger

@cmsbuild, @andrius-k, @kmaeshima, @schneiml, @nsmith-, @rekovic, @jfernan2, @thomreis can you please review it and eventually sign? Thanks.
@kreczko, @thomreis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 15, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31031/console Started: 2018/10/15 15:17

@thomreis
Copy link
Contributor

+1

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24870/31031/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2994723
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2994525
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

@thomreis @stahlleiton why no difference appears in the DQM checks? Too few events? Where is this change probed?

@thomreis
Copy link
Contributor

The code is executed in WF 1330.0 but no events pass the tag and probe selection.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 814fe85 into cms-sw:master Oct 16, 2018
@stahlleiton stahlleiton deleted the CMSL1TDPG_763_Master branch October 16, 2018 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants