Ecal Bad calib filter adding a new problematic crystal

[eioannou]

Pull Request to add the new crystal to the list of baddetEcal in the ECAL bad calib filter.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24878/6844

[cmsbuild]

A new Pull Request was created by @eioannou (Emilios Ioannou) for master.

It involves the following packages:

RecoMET/METFilters

@perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @ahinzmann, @mmarionncern, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31041/console Started: 2018/10/15 19:54

[cmsbuild]

+1
Tested at: 953f3e6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24878/31041/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24878/31041/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2994723
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2994525
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[slava77]

+1

for #24878 953f3e6

• somewhat trivial addition of a bad ECAL det ID to be checked for flagging with ecalBadCalibFilter
• jenkins tests pass and comparisons with the baseline show no differences (either due to low stats or due to lack of monitoring of the MET flags).

@eioannou
are you OK with just having this in the master/10_4_X release or do you have plans for backports?
The backports will be complicated by the requirement to preserve behavior of existing defaults.

[eioannou]

We are planning to backport it too.

[fabiocos]

+1

[fabiocos]

@perrotta concerning the backport issue, that looks similar to a new condition, right?

[fabiocos]

merge

[perrotta]

In practice, yes: one more crystal is added to the list of problematic crystals for that ​EcalBadCalibFilter, which removes events with anomalous energy intercalibrations in those specific ECAL channels. Fabio Cossutti <notifications@github.com> ha scritto:

…

@perrotta concerning the backport issue, that looks similar to a new condition, right? -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #24878 (comment)