Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 94X: add fast sim2017 PU and pmx wfs #24879

Merged

Conversation

zhenhu
Copy link
Contributor

@zhenhu zhenhu commented Oct 15, 2018

backport of #24829

This is an updated cleaner version of PR #24834 , which has been closed.
Most of the code in this PR are identical as the original PR #24829 , although I have to change some part to make it compatible with 94X.
The recycling strings have also been updated to 9_4_11_cand1, so that there will be no dataset failures in this IB.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 15, 2018

A new Pull Request was created by @zhenhu (Zhen Hu) for CMSSW_9_4_X.

It involves the following packages:

Configuration/PyReleaseValidation

@pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@zhenhu
Copy link
Contributor Author

zhenhu commented Oct 15, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 15, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31042/console Started: 2018/10/15 20:16

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24879/31042/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 109
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721222
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@zhenhu
Copy link
Contributor Author

zhenhu commented Oct 15, 2018

please test workflow 25400.17, 250399.17, 250400.17, 250402.171

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 15, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31050/console Started: 2018/10/16 00:13

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24879/31050/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24879/250399.17_FS_PREMIXUP17_PU50+FS_PREMIXUP17_PU50
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24879/250400.17_ZEE_13+FS_ZEE_13_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24879/250402.171_TTbar_13+FS_PREMIXUP17_PU50+FS_TTbar_13_PRMXLOCALUP17_PU50+HARVESTUP17FS
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24879/25400.17_ZEE_13+FS_ZEE_13_UP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 102
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721229
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@zhenhu
Copy link
Contributor Author

zhenhu commented Oct 16, 2018

+1

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

@kpedro88 the backport looks ok, please check and sign it in case
We should add this for CMSSW_9_4_11_cand2 build

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 289c257 into cms-sw:CMSSW_9_4_X Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants