Update rechit calibration: dEdX weights, fCPerMIP, thickness corrections

[apsallid]

This PR includes the work done with @rovere, @felicepantaleo, @amartelli, @clelange on the new dEdX weights, fCPerMIP and thickness correction factors in the context of the HGCal DPG.

The slides describing the calculation can be seen in this link.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24882/6850

[cmsbuild]

A new Pull Request was created by @apsallid for master.

It involves the following packages:

RecoLocalCalo/HGCalRecProducers

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@edjtscott, @vandreev11, @sethzenz, @felicepantaleo, @rovere, @lgray, @cseez, @pfs, @kpedro88 this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31060/console Started: 2018/10/16 11:52

[cmsbuild]

+1
Tested at: 5b157c5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24882/31060/summary.html

[cmsbuild]

Comparison job queued.

[kpedro88]

since the EE and FH values are the same, it would be better to assign them to a variable

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24882/6861

[cmsbuild]

+1
Tested at: 831a913
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24882/31083/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24882/31083/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2994843
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2994645
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[kpedro88]

@apsallid do you have some slides/plots demonstrating the goodness of the calibration for the new geometry?

[apsallid]

@kpedro88 Yes, the slides are here:

https://indico.cern.ch/event/763724/contributions/3170075/attachments/1729687/2794958/HGaldEdxandHitCalib_08_10_2018_CMG_HGCal.pdf

[kpedro88]

@apsallid thanks, please update the PR description with that link for posterity

[kpedro88]

+upgrade

[apsallid]

@kpedro88 ok added, thanks a lot!

[perrotta]

Tested this PR with workflow 24034, which refers to the geometry 2023D28 which includes the phase2_hgcalV9 modifier addressed here.
The workflow runs to completion, and this could be enough for accepting this PR.

In the step3 log I found repeatedly this warning message:

%MSG-e PFEGammaProducer:  PFEGammaProducer:particleFlowEGamma  23-Oct-2018 15:57:07 CEST Run: 1 Event: 19
PFBLOCKALGO BUG!!!! Found a SuperCluster in a block by itself!
%MSG
%MSG-e PFEGammaProducer:  PFEGammaProducer:particleFlowEGamma  23-Oct-2018 15:57:07 CEST Run: 1 Event: 19
PFBLOCKALGO BUG!!!! Found a SuperCluster in a block by itself!
%MSG

I imagine it may have more to do with the scenario itself, and not to this calibration update: in any case, it is probably worth having a look.

[perrotta]

By the way, the message above also shows up in the baseline.

[perrotta]

+1

• The relevant workflows run to completion with this PR included
• Performance of the new calibration has been evaluated as good by the proponents
• Jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1