-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.4.X][Change GT] Update HI MC ECAL GT + 2019 GT Geom. fix #24916
Conversation
The code-checks are being triggered in jenkins. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24916/6882 |
The tests are being triggered in jenkins. |
A new Pull Request was created by @lpernie (Luca Pernie) for master. It involves the following packages: Configuration/AlCa @cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Tested at: 3264022 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test runtestPhysicsToolsPatAlgos had ERRORS |
Comparison job queued. |
@fabiocos I keep getting this problem: |
Comparison is ready Comparison Summary:
|
please test |
The tests are being triggered in jenkins. |
Once again an error not coming from the PR: |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 the changes in DQM histograms are all concentrated in the HI wf 158 |
2018 HI MC GT
. 6 Tags have been updated from ECAL:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/103X_upgrade2018_realistic_HI_v6/103X_upgrade2018_realistic_HI_v7
2019 GT
. Geometry Fix for Ianna
In order to consider the ECAL Tag update in the HI Queue, these PR need to be integrated before the injection of the 10_3_0 PbPb MC relvals, as discussed today at the PPD coordination.