Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.4.X][Change GT] Update HI MC ECAL GT + 2019 GT Geom. fix #24916

Merged
merged 1 commit into from
Oct 20, 2018

Conversation

lpernie
Copy link
Contributor

@lpernie lpernie commented Oct 17, 2018

2018 HI MC GT

. 6 Tags have been updated from ECAL:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/103X_upgrade2018_realistic_HI_v6/103X_upgrade2018_realistic_HI_v7

2019 GT

. Geometry Fix for Ianna

In order to consider the ECAL Tag update in the HI Queue, these PR need to be integrated before the injection of the 10_3_0 PbPb MC relvals, as discussed today at the PPD coordination.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@lpernie
Copy link
Contributor Author

lpernie commented Oct 17, 2018

please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 17, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31114/console Started: 2018/10/17 19:18

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lpernie (Luca Pernie) for master.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Tested at: 3264022

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24916/31114/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@lpernie
Copy link
Contributor Author

lpernie commented Oct 17, 2018

@fabiocos I keep getting this problem:
stat: cannot stat `dqm_empty.root': No such file or directory
read_missing_file_cfg.py ------------------------------------------------------------
17-Oct-2018 19:27:01 CEST Initiating request to open file file:dqm_missing.root
----- Begin Fatal Exception 17-Oct-2018 19:27:01 CEST-----------------------
An exception of category 'FileOpenError' occurred while
[0] Calling InputSource::readFile_
[1] Opening DQM Root file
[2] Calling StorageFactory::open()
[3] Calling File::sysopen()
Exception Message:
Failed to open the file 'dqm_missing.root'
Input file file:dqm_missing.root was not found, could not be opened, or is corrupted.
Additional Info:
[a] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24916/31114/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 321 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2994843
  • DQMHistoTests: Total failures: 1799
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2992847
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@lpernie
Copy link
Contributor Author

lpernie commented Oct 18, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31116/console Started: 2018/10/18 02:33

@lpernie
Copy link
Contributor Author

lpernie commented Oct 19, 2018

Once again an error not coming from the PR:
----- Begin Fatal Exception 19-Oct-2018 14:55:24 CEST-----------------------
An exception of category 'FallbackFileOpenError' occurred while
[0] Constructing the EventProcessor
[1] Constructing input source of type PoolSource
[2] Calling RootFileSequenceBase::initTheFile()
[3] Calling StorageFactory::open()
[4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://cms-xrd-global.cern.ch//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root'

@lpernie
Copy link
Contributor Author

lpernie commented Oct 19, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 19, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31173/console Started: 2018/10/19 17:46

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24916/31173/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 495 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2994843
  • DQMHistoTests: Total failures: 1798
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2992848
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@lpernie
Copy link
Contributor Author

lpernie commented Oct 19, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

the changes in DQM histograms are all concentrated in the HI wf 158

@cmsbuild cmsbuild merged commit e31bd69 into cms-sw:master Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants