Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Central skims for 2018 PbPb run #24927

Merged
merged 1 commit into from Oct 30, 2018

Conversation

mandrenguyen
Copy link
Contributor

Replace central skim cffs from 2016 pPb with ones for this year's 2018 PbPb run.
These will only be testable once the HLT menu is integrated, which should be soon.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master.

It involves the following packages:

Configuration/Skimming
Configuration/StandardSequences

@cmsbuild, @prebello, @zhenhu, @pgunnell, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

@mandrenguyen do we really need to drop old stuff, would not be an era-based approach possible?

@mandrenguyen
Copy link
Contributor Author

@fabiocos I don't really see the motivation for keeping the 2016 pA central skims around. We won't have more pA data until midway through Run 3 at earliest. Even then we would likely not reuse the same skimming configurations. I can bring those old cffs back if you prefer. However, I would not bother with trying to control which prompt skims are run based on an era. AFAIK central skims are implemented directly in the T0 configuration.

@fabiocos
Copy link
Contributor

@prebello @zhenhu @davidlange6 do we have a general policy for maintaining older skims?
At present there is nothing in the release for PbPb as far as I can see, and the pA skims of 5_3_X had gone since a while

@davidlange6
Copy link
Contributor

davidlange6 commented Oct 26, 2018 via email

@prebello
Copy link
Contributor

Hi @fabiocos about Skims, @kfjack has contacted HIN group after PdmV request to get the necessary inputs and can give more details. Please, @mandrenguyen @kkrajczar could you comment on the thread "status SKIM matrix for HI"?
Thank you‎

@mandrenguyen
Copy link
Contributor Author

@prebello
After this PR is merged, I think we just need to provide the mapping between PD and central skim to the T0 hypernews. @kfjack can correct me if that's wrong.

Please note that @kkrajczar is no longer in CMS

Regarding maintaining older skims, the 2016 pA skims will not be reused in Run 3.

@fabiocos
Copy link
Contributor

please test workflow 140.56,140.57

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 30, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31355/console Started: 2018/10/30 09:06

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@prebello
Copy link
Contributor

+1

tests approved

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24927/31355/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24927/140.56_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24927/140.57_RunHI2018Reduced+RunHI2018Reduced+RECOHID18+HARVESTDHI18

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2994843
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2994644
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

+operations

the update of the StandardSequences is coherent with the PR purpose

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 01c00c2 into cms-sw:master Oct 30, 2018
@fabiocos
Copy link
Contributor

@mandrenguyen in my check I missed that 140.54 is using the PA skim, apologies for this. As PA sequences do not harm, I will restore them, although I think that this workflow has mostly a technical use.

@mandrenguyen
Copy link
Contributor Author

@fabiocos Ok, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants