Further CaloL2 O2O updates (supersedes #24922)

[bundocka]

Supersedes #24922
Not critical for #24869

This PR brings the CaloL2 O2O fully inline with the firmware.

Remove etSumX & etSumY calibration LUTs: these are replaced by met & metHF calibration LUTs
Add metPhi & metHFPhi calibration LUTs
Add demux LUTs to conversion script
Update caloParams & helper class
NB. The etSumXCalibration & etSumYCalibration nodes that have been repurposed in CaloParamsHelper.h and CaloParamsHelperO2O.h were never used anywhere in CMSSW, so this is backwards compatible.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24931/6905

[cmsbuild]

A new Pull Request was created by @bundocka for master.

It involves the following packages:

L1Trigger/L1TCalorimeter
L1TriggerConfig/L1TConfigProducers
L1TriggerConfig/Utilities

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24931/6906

[cmsbuild]

Pull request #24931 was updated. @nsmith-, @rekovic, @cmsbuild, @thomreis can you please check and sign again.

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31143/console Started: 2018/10/18 20:14

[cmsbuild]

+1
Tested at: 43f6876
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24931/31143/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
43f6876
3479750
a97dbe5
58a578e
8420a96
1fe74c5
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24931/31143/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24931/31143/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24931/31143/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2994843
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2994645
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[thomreis]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@thomreis @bundocka in which plots is the effect of this update of the emulator supposed to appear? Funnily we get changes in many L1T checks but not here, is this due to just a small statistics? Were effects verified in offline tests?

[fabiocos]

@bundocka @thomreis @rekovic ping

[fabiocos]

@bundocka @thomreis @rekovic if this is needed for HI data taking please clarify asap

[bundocka]

@fabiocos This update shouldn't affect the emulator at all, it just renames two caloParam nodes that were never used anywhere, and adds two new ones, so that the O2O is consistent with all the configurable parameters at CaloL2. This is not critical for HI data taking, and can be merged into the L1T O2O release manually.

[fabiocos]

+1