DQM TriggerMatch Monitor to Watch the Trigger matching feature in pat::Muon

[bmahakud]

No description provided.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24936/6908

[cmsbuild]

A new Pull Request was created by @bmahakud (Bibhuprasad Mahakud) for master.

It involves the following packages:

DQMOffline/Muon

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@barvic, @bellan, @abbiendi, @jhgoh, @calderona, @HuguesBrun, @ptcox, @battibass, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[andrius-k]

Hi @bmahakud, I can't seem to find you in the DQM Contacts list, could you please shortly introduce yourself?

[folguera]

Dear @andrius-k,
@bmahakud is our reco-muon contact, we need this PR to monitor a trigger-matching variable that we've introduced in the reco::muon object. Please review this and let us know if it can be merged or not.
There is no need to add Bibhu to the DQM contact list as he is normally not involved in this.

[bmahakud]

@andrius-k
Please review the code. We have another PR which needs to be merged before this one . This PR uses a functionality that the other PR have (PR#24901). Once you review is done we will modify things if needed and wait for the other PR to be merged before it is tested.

[andrius-k]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31160/console Started: 2018/10/19 14:15

[cmsbuild]

-1

Tested at: adce5d4

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24936/31160/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

• Build:

I found compilation error when building:

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_4_X_2018-10-18-2300/src/DQMOffline/Muon/src/TriggerMatchMonitor.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_4_X_2018-10-18-2300/src/DQMOffline/Muon/src/EfficiencyPlotter.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_4_X_2018-10-18-2300/src/DQMOffline/Muon/src/MuonRecoOneHLT.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_4_X_2018-10-18-2300/src/DQMOffline/Muon/src/MuonRecoAnalyzer.cc 
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_4_X_2018-10-18-2300/src/DQMOffline/Muon/src/TriggerMatchMonitor.cc: In member function 'virtual void TriggerMatchMonitor::analyze(const edm::Event&, const edm::EventSetup&)':
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_4_X_2018-10-18-2300/src/DQMOffline/Muon/src/TriggerMatchMonitor.cc:133:31: error: passing 'const pat::Muon' as 'this' argument discards qualifiers [-fpermissive]
       if(patMuon.triggered(ptr)){
                               ^
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_4_X_2018-10-18-2300/src/DQMOffline/Muon/interface/TriggerMatchMonitor.h:35:0,
                 from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_4_X_2018-10-18-2300/src/DQMOffline/Muon/src/TriggerMatchMonitor.cc:6:
/cvmfs/cms-ib.cern.ch/nweek-02546/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_4_X_2018-10-18-2300/src/DataFormats/PatCandidates/interface/Muon.h:322:12: note:   in call to 'bool pat::Muon::triggered(const char*)'


• Clang:

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 16 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[andrius-k]

@bmahakud could you please also run changed code through clang-format to make sure formatting and indentation is correct?

[bmahakud]

@andrius-k Thanks for the suggestion. Please let me take 1-2 days more. One of the error "if(patMuon.triggered(ptr))" is because the other PR #24901 is not merged yet. This took bit more time than expected because as some root problem was going on in the IB. Mostly done(#24901). I will just commit again in 1-2 days with updated code implementing your suggestions.

[andrius-k]

@bmahakud sure, no problem.

[bmahakud]

Another PR created #24988 for this . Several changes have been added wrt to this PR